On Thu, Jun 25, 2020 at 02:40:17PM +0200, Michal Hocko wrote:
> On Thu 25-06-20 12:31:22, Matthew Wilcox wrote:
> > Similar to memalloc_noio() and memalloc_nofs(), memalloc_nowait()
> > guarantees we will not sleep to reclaim memory. Use it to simplify
> > dm-bufio's allocations.
>
> memalloc_nowait is a good idea! I suspect the primary usecase would be
> vmalloc.
That's funny. My use case is allocating page tables in an RCU protected
page fault handler. Jens' use case is allocating page cache. This one
is a vmalloc consumer (which is also indirectly page table allocation).
> > @@ -877,7 +857,9 @@ static struct dm_buffer
> > *__alloc_buffer_wait_no_callback(struct dm_bufio_client
> > */
> > while (1) {
> > if (dm_bufio_cache_size_latch != 1) {
> > - b = alloc_buffer(c, GFP_NOWAIT | __GFP_NORETRY |
> > __GFP_NOMEMALLOC | __GFP_NOWARN);
> > + unsigned nowait_flag = memalloc_nowait_save();
> > + b = alloc_buffer(c, GFP_KERNEL | __GFP_NOMEMALLOC |
> > __GFP_NOWARN);
> > + memalloc_nowait_restore(nowait_flag);
>
> This looks confusing though. I am not familiar with alloc_buffer and
> there is quite some tweaking around __GFP_NORETRY in alloc_buffer_data
> which I do not follow but GFP_KERNEL just struck my eyes. So why cannot
> we have
> alloc_buffer(GFP_NOWAIT | __GFP_NOMEMALLOC | __GFP_NOWARN);
Actually, I wanted to ask about the proliferation of __GFP_NOMEMALLOC
in the block layer. Am I right in thinking it really has no effect
unless GFP_ATOMIC is set? It seems like a magic flag that some driver
developers are sprinkling around randomly, so we probably need to clarify
the documentation on it.
What I was trying to do was just use the memalloc_nofoo API to control
what was going on and then the driver can just use GFP_KERNEL. I should
probably have completed that thought before sending the patches out.
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
