On Wed, 5 May 2021, Melvin Vermeeren wrote:

> On Wednesday, 5 May 2021 22:05:35 CEST Mikulas Patocka wrote:
> > Yes.
> 
> I fail to understand why that would be desired behaviour, as I see it it is 
> conflicting with current documentation in integritysetup(8):

So, we can ask Milan to update the manpage.

> > --integrity-recalculate
> > Automatically recalculate integrity tags in kernel on activation. The device
> > can be used during automatic integrity recalculation but becomes fully
> > integrity protected only after the background operation is finished. This
> > option is available since the Linux kernel version 4.19.
> 
> The device in SSD with discard case never receives integrity protection 
> because the metadata is filled with discard filler. Could you explain the 
> reasoning behind the patch?

It will receive integrity protection for the newly written data.

If you create an integrity device and make a filesystem on it, the newly 
written data matters. The old data that were on the filesystem before 
formatting it don't care and don't need to be protected.

> Thanks,

Mikulas

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel

Reply via email to