Hi, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on scsi/for-next next-20210628] [cannot apply to dm/for-next block/for-next song-md/md-next v5.13] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/mwilck-suse-com/scsi-dm-dm_blk_ioctl-implement-failover-for-SG_IO-on-dm-multipath/20210628-175410 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: x86_64-randconfig-r032-20210628 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 4c92e31dd0f1bd152eda883af20ff7fbcaa14945) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/259453ca972ae531cfdca07cbf4d6bb09b8f8c9f git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review mwilck-suse-com/scsi-dm-dm_blk_ioctl-implement-failover-for-SG_IO-on-dm-multipath/20210628-175410 git checkout 259453ca972ae531cfdca07cbf4d6bb09b8f8c9f # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All warnings (new ones prefixed by >>): >> block/scsi_ioctl.c:937:6: warning: logical not is only applied to the left >> hand side of this bitwise operator [-Wlogical-not-parentheses] if (!hdr->info & SG_INFO_CHECK) ^ ~ include/linux/compiler.h:56:47: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~~ include/linux/compiler.h:58:52: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ block/scsi_ioctl.c:937:6: note: add parentheses after the '!' to evaluate the bitwise operator first block/scsi_ioctl.c:937:6: note: add parentheses around left hand side expression to silence this warning >> block/scsi_ioctl.c:937:6: warning: logical not is only applied to the left >> hand side of this bitwise operator [-Wlogical-not-parentheses] if (!hdr->info & SG_INFO_CHECK) ^ ~ include/linux/compiler.h:56:47: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~~ include/linux/compiler.h:58:61: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ block/scsi_ioctl.c:937:6: note: add parentheses after the '!' to evaluate the bitwise operator first block/scsi_ioctl.c:937:6: note: add parentheses around left hand side expression to silence this warning >> block/scsi_ioctl.c:937:6: warning: logical not is only applied to the left >> hand side of this bitwise operator [-Wlogical-not-parentheses] if (!hdr->info & SG_INFO_CHECK) ^ ~ include/linux/compiler.h:56:47: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~~ include/linux/compiler.h:58:86: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ include/linux/compiler.h:69:3: note: expanded from macro '__trace_if_value' (cond) ? \ ^~~~ block/scsi_ioctl.c:937:6: note: add parentheses after the '!' to evaluate the bitwise operator first block/scsi_ioctl.c:937:6: note: add parentheses around left hand side expression to silence this warning 3 warnings generated. vim +937 block/scsi_ioctl.c 931 932 blk_status_t sg_io_to_blk_status(struct sg_io_hdr *hdr) 933 { 934 int result; 935 blk_status_t sts; 936 > 937 if (!hdr->info & SG_INFO_CHECK) 938 return BLK_STS_OK; 939 940 result = hdr->status | 941 (hdr->msg_status << 8) | 942 (hdr->host_status << 16) | 943 (hdr->driver_status << 24); 944 945 sts = __scsi_result_to_blk_status(&result, result); 946 hdr->host_status = host_byte(result); 947 948 return sts; 949 } 950 EXPORT_SYMBOL(sg_io_to_blk_status); 951 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
-- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
