On 2021/11/18 8:47, Benjamin Marzinski wrote: > On Tue, Nov 16, 2021 at 10:00:53PM +0800, lixiaokeng wrote: >> In _DEBUG_ mode, MALLOC/STRDUP/REALLOC and FREE will record >> the memory usage. Match them. > > This looks fine, but personally, I'd rather just have all the DEBUG > memory code removed. If people want to check memory usage, there's > always valgrind. > > -Ben > >> If MALLOC/STRDUP/REALLOC and FREE is unnecessary, I'll remove this patch in this series and make a patch remove them latter. What is Martin's opinion? Regards Lixiaokeng -- dm-devel mailing list [email protected] https://listman.redhat.com/mailman/listinfo/dm-devel
- [dm-devel] [PATCH 1/5] Fix potential null pointer deref... lixiaokeng
- Re: [dm-devel] [PATCH 1/5] Fix potential null poin... Benjamin Marzinski
- [dm-devel] [PATCH 2/5] remove unnecessary memset lixiaokeng
- Re: [dm-devel] [PATCH 2/5] remove unnecessary mems... Benjamin Marzinski
- [dm-devel] [PATCH 3/5] remove unnecessary free lixiaokeng
- Re: [dm-devel] [PATCH 3/5] remove unnecessary free Benjamin Marzinski
- [dm-devel] [PATCH 5/5] add prflag to path lixiaokeng
- [dm-devel] [PATCH 4/5] Match FREE and MALLOC/STRDUP/REA... lixiaokeng
- Re: [dm-devel] [PATCH 4/5] Match FREE and MALLOC/S... Benjamin Marzinski
- Re: [dm-devel] [PATCH 4/5] Match FREE and MALL... lixiaokeng
