kpartx was closing the whole device after it read the partition information off it. This allowed a race, where the device could be removed and another one created with the same major:minor, after kpartx read the partition information but before it created the partition devices.
Signed-off-by: Benjamin Marzinski <[email protected]> --- kpartx/kpartx.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/kpartx/kpartx.c b/kpartx/kpartx.c index 3c499995..1d568c9e 100644 --- a/kpartx/kpartx.c +++ b/kpartx/kpartx.c @@ -441,12 +441,7 @@ main(int argc, char **argv){ if (n >= 0) printf("%s: %d slices\n", ptp->type, n); #endif - - if (n > 0) { - close(fd); - fd = -1; - } - else + if (n <= 0) continue; switch(what) { @@ -666,9 +661,9 @@ main(int argc, char **argv){ if (n > 0) break; } + if (fd != -1) + close(fd); if (what == LIST && loopcreated) { - if (fd != -1) - close(fd); if (del_loop(device)) { if (verbose) fprintf(stderr, "can't del loop : %s\n", -- 2.17.2 -- dm-devel mailing list [email protected] https://listman.redhat.com/mailman/listinfo/dm-devel
