Re: [dm-devel] [PATCH 16/21] libmultipath: update_bindings_file: don't log temp file name

[Benjamin Marzinski]

On Fri, Sep 01, 2023 at 08:02:29PM +0200, mwi...@suse.com wrote:
> From: Martin Wilck <mwi...@suse.com>
> 
> The name of the temp file is unlikely to be helpful for uses,
> and hard to predict in the unit test. Omit it.
> 
Reviewed-by: Benjamin Marzinski <bmarz...@redhat.com>
> Signed-off-by: Martin Wilck <mwi...@suse.com>
> ---
>  libmultipath/alias.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/libmultipath/alias.c b/libmultipath/alias.c
> index c26f37c..9ca5da8 100644
> --- a/libmultipath/alias.c
> +++ b/libmultipath/alias.c
> @@ -167,8 +167,7 @@ static int update_bindings_file(const Bindings *bindings,
>       rc = write_bindings_file(bindings, fd);
>       pthread_cleanup_pop(1);
>       if (rc == -1) {
> -             condlog(1, "failed to write new bindings file %s",
> -                     tempname);
> +             condlog(1, "failed to write new bindings file");
>               unlink(tempname);
>               return rc;
>       }
> -- 
> 2.41.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel