Martin,

If you recall, in 2.066, the AA code was changed to use typeinfo.equals instead 
of typeinfo.compare.

This caused a so called "regression", which prompted Walter to undo the work 
that disallows AA keys with compare override but not equals override (a knee 
jerk reaction IMO to the term "regression"). I believe you had written the code 
for and pushed for that error. I haven't seen your voice on that change, but I 
thought it was not a good idea to remove that error.

I don't think it has been undone for classes either, so at least current git 
head is inconsistent.

Your thoughts? Releasing 2.066.1 as is will allow code built to expect opCmp to 
work as an AA key will silently fail as we discussed (I tested this a few weeks 
ago).

Relevant discussion: https://issues.dlang.org/show_bug.cgi?id=13179

On Oct 8, 2014, at 11:01 AM, Martin Nowak via dmd-beta <[email protected]> 
wrote:

> I want to release 2.066.1 pretty soon (by the end of this week).
> Are there any know issues that still need to be addressed?
> 
> One thing that I'd like to get in is readding std.metastrings, because it's 
> removal in 2.066 broke every vibe.d program.
> https://github.com/D-Programming-Language/phobos/pull/2596
> _______________________________________________
> dmd-beta mailing list
> [email protected]
> http://lists.puremagic.com/mailman/listinfo/dmd-beta


_______________________________________________
dmd-beta mailing list
[email protected]
http://lists.puremagic.com/mailman/listinfo/dmd-beta

Reply via email to