kenji hara, el 20 de August a las 11:40 me escribiste: > I had been invited as dmd committer a month ago, but haven't been able > to consume pull requests. > > The top three of pulls at 2012/08/20: > 37 pulls : my front-end changes > 17 pulls : yebblies's front-end changes > 13 pulls : dawgfoto's backend and front-end changes > -> 67/103 (65% of all pulls) > and, as far as I seen half of them are trivial bug fixes and LGTM. > > But they are yet not merged by the following reasons. > #1. Some of them are mine, so I cannot merge without others reviewing. > #2. Some of them are already outdated, so I cannot merge them without > small fix-up. > But, even if I add some fix-ups to them, I can not merge them by > the reason #1 .
I think ideally somebody should review your commits, but if you've been offered commit rights, then it's implied you don't *need* review (nobody reviews Walter commits, not at least before they are pushed to the repo). Again, it would be ideal if somebody else review the patch, but I don't think it should be a blocker. But that's just *my* POV and I have no idea what does it mean for Walter to give commit rights (I guess is push rights in git terminology). -- Leandro Lucarella (AKA luca) http://llucax.com.ar/ ---------------------------------------------------------------------- GPG Key: 5F5A8D05 (F8CD F9A7 BF00 5431 4145 104C 949E BFB6 5F5A 8D05) ---------------------------------------------------------------------- Are you such a dreamer? To put the world to rights? I'll stay home forever Where two & two always makes up five _______________________________________________ dmd-internals mailing list [email protected] http://lists.puremagic.com/mailman/listinfo/dmd-internals
