Hi Erwan, Jerry, > Le sam. 21 sept. 2019 à 12:44, Erwan Velu <erwanalia...@gmail.com> a écrit : > > Oh yes. I'll update the man page as well. Thanks for the review.
Yes, thanks for the preliminary review Jerry. > > Le ven. 20 sept. 2019 à 23:04, Jerry Hoemann <jerry.hoem...@hpe.com> a > > écrit : > >> On Tue, Sep 17, 2019 at 05:50:00PM +0200, Erwan Velu wrote: > >> > I faced a situation where some vendors like HPe encodes the release > >> > version of the bios into the bios_revision field. > >> > > >> > Dmidecode only exports the bios-version which is not relevant here. So > >> > I simply added a new entry of the -s option to expose this. > >> > > >> > I performed the same operation for the firmware_revision which helps > >> > extraction the BMC version of the server. > >> > > >> > Both are useful when tracking firmware versions across an infrastructure. Makes sense to me. But your implementation breaks "dmidecode -q -t 0". Remember that -s implies -q but -q also exists as a separated option. In order to fix that, you need to move printing the labels outside the new functions and back to the calling sites. Also: > @@ -134,7 +134,7 @@ form. The generated file is suitable to > later. > .TP > .BR " " " " "--from-dump FILE" > -Read the DMI data from a binary file previously generated using > +Read the DMI data from a binary file previously generated using > \fB--dump-bin\fR. > .TP > .BR " " " " "--no-sysfs" Please do not include unrelated white-space cleanups in your patches. Style clean-up patches are welcome but then they should do only that. Thanks, -- Jean Delvare SUSE L3 Support _______________________________________________ https://lists.nongnu.org/mailman/listinfo/dmidecode-devel
