Hi Jerry, On Fri, 3 Jun 2022 07:17:56 -0600, Jerry Hoemann wrote: > Decode HPE OEM Record 194: Super IO Enable/Disable Features > > Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com> > --- > dmioem.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/dmioem.c b/dmioem.c > index 759d778..f15247a 100644 > --- a/dmioem.c > +++ b/dmioem.c > @@ -364,6 +364,27 @@ static int dmi_decode_hp(const struct dmi_header *h) > > switch (h->type) > { > + case 194: > + /* > + * Vendor Specific: Super IO Enable/Disable Features > + * > + * Offset | Name | Width | Description > + * ------------------------------------- > + * 0x00 | Type | BYTE | 0xC2, Super IO > Enable/Disable Structure Indicator > + * 0x01 | Length | BYTE | Length of structure > + * 0x02 | Handle | WORD | Unique handle > + * 0x04 | Dev Status | Varies| Device Status > + */ > + pr_handle_name("%s ProLiant Super IO Enable/Disable > Indicator", company); > + feat = data[0x04]; > + pr_attr("Serial Port A", "%s", (feat & 0x01) ? > "Enabled" : "Disabled"); > + pr_attr("Serial Port B", "%s", (feat & 0x02) ? > "Enabled" : "Disabled"); > + pr_attr("Parallel Port", "%s", (feat & 0x04) ? > "Enabled" : "Disabled"); > + pr_attr("Floppy Disk Port", "%s", (feat & 0x08) ? > "Enabled" : "Disabled"); > + pr_attr("Virtual Serial Port", "%s", (feat & 0x10) ? > "Enabled" : "Disabled"); > + > + break; > + > case 199: > /* > * Vendor Specific: CPU Microcode Patch
Committed, with the following minor changes: * Changed "Varies" to "BYTE" as the width of field at offset 0x04. * Added a length check, as we have for all other structures. * Used bit shifting to represent the masks, as we do in dmi_hp_240_attr(). * Removed a blank line. Thanks for your contribution. -- Jean Delvare SUSE L3 Support _______________________________________________ https://lists.nongnu.org/mailman/listinfo/dmidecode-devel