On Wed, 7 Jun 2023 00:27:57 -0600, Jerry Hoemann wrote:
> Correct mask in HPE OEM 216 type 1. Should be byte, not nibble.
>
> Only display internal version number when bit is set to indicate it is
> valid.
>
> Fixes: 9d2bbd5db427 ("dmioem: Decode HPE OEM Record 216")
>
> Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com>
> ---
> dmioem.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/dmioem.c b/dmioem.c
> index 186b250..5e5c2da 100644
> --- a/dmioem.c
> +++ b/dmioem.c
> @@ -388,8 +388,10 @@ static void dmi_hp_216_version(u8 format, u8 *data)
> pr_attr(name, "No Version Data");
> break;
> case 1:
> - pr_attr(name, "%c.%d.%d", data[0] & (1 << 7) ? 'B' : 'R',
> - data[0] & 0x7, data[1] & 0x7);
> + if (data[0] >> 7)
> + pr_attr(name, "0x%02X B.0x%02X", data[1] & 0x7F,
> data[0] & 0x7F);
> + else
> + pr_attr(name, "0x%02X", data[1] & 0x7F);
> break;
> case 2:
> pr_attr(name, "%d.%d", data[0] >> 4, data[0] & 0x0f);
Applied, thanks.
--
Jean Delvare
SUSE L3 Support
