On Sat, Jan 06, 2018 at 04:41:57PM +0300, Hleb Valoshka wrote: > On 2018-01-05 20:08, Andreas Messer wrote: > > If anyone like to try it out, checkout branch suites/experimental > > from https://git.devuan.org/amesser/elogind.git and build with > > debbuild. This is my first package, comments are welcome.
(Note: in the comments below, my opinions are those of a Debian Developer who's not active in Devuan. I'm these days the second most active package reviewer, though, so probably they're worth some heed. I did not even look at the package yet, though.) > -> d/changelog > elogind (234.4-devuan1) experimental; urgency=medium > > This package is native to Devuan, so it's version should be 234.4-1 or > 234.4-1~exp1. I believe that it's still better to mark it as Devuan specific, especially that it's wanted for Debian as well. Less confusion this way. > -> d/control & d/libelogind-data.install > > libelogind-data contains only l10n files, so there is no need for a > separate package, merge libelogind-data into libelogind. It's a bad idea to mix arch-indep files with arch-specific. Even worse, if this library is to be ever used by programs other than elogind itself (and if it were not, it shouldn't be a library), it would make it impossible to multiarchize it. > And I suppose there is no need to check for upstart, abandoned and > unsupported afair in Dev1 sustem. And in any maintained derivative. (I'd comment more once I get around to looking at the package itself.) Meow! -- // If you believe in so-called "intellectual property", please immediately // cease using counterfeit alphabets. Instead, contact the nearest temple // of Amon, whose priests will provide you with scribal services for all // your writing needs, for Reasonable And Non-Discriminatory prices. _______________________________________________ Dng mailing list [email protected] https://mailinglists.dyne.org/cgi-bin/mailman/listinfo/dng
