Completely aside from arguments over the merits of autotools, this patch is not production-ready.
It makes unrelated changes. Removal of the copyright notice is certainly not necessary for use of autotools. It breaks the documentation, which will no longer accurately describe the steps needed for build and installation. And dumping a patch out on a mailing list without introduction or explanation is inadvisable if you want it to be favorably received. Especially when it's the first message ever sent by that user to the list. You've not participated in any discussion. You've done nothing to show that you actually understand the "typical" deployment of dnsmasq. OpenSuSE is quite atypical of dnsmasq installations. Have you tested the patch on any other platforms? Simon will decide what to do with your patch, but I suggest that if you address some of these concerns he's more likely to be positive toward it. On Sun, Sep 9, 2012 at 12:57 AM, Cristian Rodríguez <crrodrig...@opensuse.org> wrote: > El dom 09 sep 2012 02:03:11 CLST, Shantanu Gadgil escribió: > >> If this is done, won't the autotools chain will be a prerequisite for >> dnsmasq to be built. >> >> Maybe OK for Linux OSes ... not necessary for other platforms/OSes (think >> Solaris, AIX, and even more obscure, etc). >> Why the overhead?!? >> >> I really like the *really really simple* Makefile based build and not at >> all in favour of this! > > > > This **really really simple** makefiles requires constant patching and > maintenance for distributions, in short they are a pain in the ass. > > Linux, BSDs, Solaris have automake/autoconf..etc and I could not care less > about obscure systems. what matters is what most people use. > > > > > _______________________________________________ > Dnsmasq-discuss mailing list > Dnsmasq-discuss@lists.thekelleys.org.uk > http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss _______________________________________________ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
