On 10/04/17 00:09, Floris Bos wrote: > On 04/09/2017 11:28 PM, Simon Kelley wrote: >> Patch accepted, with one change >> >> >>> snprintf(daemon->namebuff+oldlen, >>> sizeof(daemon->namebuff)-oldlen, "%.2x-%.2x-%.2x-%.2x-%.2x-%.2x/", >> >> daemon->namebuff is a char *, so sizeof(daemon->namebuff) is 4 or 8 and >> sizeof(daemon->namebuff)-oldlen is a negative number which is a large >> positive number when promoted to unsigned size_t. > > Ah, you are right. > > Somehow I had the impression it was a fixed size array, on which > sizeof() do would work. > Probably confused it with the other namebuff in tftp_request ( char > namebuff[IF_NAMESIZE]; ) > > Sorry, and thanks for the commit. > >
No problem. Security, I have to take responsibility for. My tip for sound sleep is not to be responsible for C code which runs as root on 100 million devices :) Cheers, Simon.
Description: OpenPGP digital signature
_______________________________________________ Dnsmasq-discuss mailing list Dnsmasqfirstname.lastname@example.org http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss