On Wed, Oct 04, 2017 at 10:20:24PM -0700, ros...@gmail.com wrote:
> 
> Compile time. Looks fine to me. To add to my commit message,
> strlen(NULL) causes a segmentation fault, meaning intname cannot be
> NULL.
> 
> Actually I wonder how many more warnings I can find like this...

Probably a lot, but you should stop.

Forgive me, but this is code you don't appear to understand and have not
even tested.  Some of it introduces nasty side effects and some of it
even outright inverts logic.  Blindly pasting static analysis output is
not how programs are maintained, but it does introduce a lot of work for
those of us who care sufficiently to review the code.

This code introduces bugs and does not even have the grace to improve
functionality in the process.

khm

_______________________________________________
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss

Reply via email to