On Monday 26 February 2018 19:59:53 Petr Menšík wrote:
> -         for (arg += strlen(arg)+1; *arg == ' '; arg++);
> +         for (arg += arglen+1; *arg && isspace(*arg); arg++);


Just one note about this change. Function isspace() is implemented
according to current locale and basically every locale can have
different set of characters marked as "space". E.g. in C locale
isspace() function is truth not only for ASCII space (0x20), but also
e.g. for ASCII tab (0x09). Some people improperly use function isspace()
just because they think it matches only ASCII spaces (0x20).

Due to dependent on locale I would suggest to use explicit set of
characters... but that is just suggestion.

Pali Rohár

Attachment: signature.asc
Description: PGP signature

Dnsmasq-discuss mailing list

Reply via email to