I looked at all the nettle version dependencies, and I've cleaned it up
to work with nettle 3.x, but lost the legacy support for 2.x

I used your nettle_hash #define trick.


Cheers,

Simon.


On 16/03/18 12:31, Petr Menšík wrote:
> Sure, similar to my original version. It requires nettle 3.1 however,
> since NETTLE_VERSION_MAJOR is not available in earlier versions. But
> your version is cleaner, fine for me. Version 3.1 was released in 2015,
> should be recent enough for most people.
> 
> Thanks
> 
> On 03/15/2018 06:14 PM, Simon Kelley wrote:
>> Convergent evolution got me to
>>
>> http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=f3223fbff65d8ae9d67426dce6218fda30dee0cf
>>
>> which achieves the same thing in a slightly different way. Are you happy
>> with that?
>>
>>
>>
>> Cheers,
>>
>> Simon.
>>
>>
>> On 15/03/18 16:40, Petr Menšík wrote:
>>> Hi again,
>>>
>>> I reworked the original patch to contain fallback for older version of
>>> nettle. It will work fine on more recent version (should be a bit faster
>>> than original code), but still will compile for older libraries.
>>>
>>> On 02/26/2018 09:12 PM, Petr Menšík wrote:
>>>> Hi again,
>>>>
>>>> We at Fedora use dynamic linking for all libraries. We had breakage of
>>>> dnsmasq build more than once, because dnsmasq is using directly
>>>> nettle_hash array. If its size changes, dynamic linker will refuse to
>>>> link it. For that reason, accessing hash array directly makes trouble.
>>>> There is however special function that looks like very similar to
>>>> hash_find() of dnsmasq, that iterates the array internally. It requires
>>>> nettle 3.4, but I think that is already old enough. It would help
>>>> preventing any more linker conflict, if library data changes.
>>>>
>>>> Do you think older library version should be supported as well?
>>>>
>>>> Best regards,
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Dnsmasq-discuss mailing list
>>>> Dnsmasq-discuss@lists.thekelleys.org.uk
>>>> http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
>>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Dnsmasq-discuss mailing list
>>> Dnsmasq-discuss@lists.thekelleys.org.uk
>>> http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
>>>
>>
>>
>>
>>
>> _______________________________________________
>> Dnsmasq-discuss mailing list
>> Dnsmasq-discuss@lists.thekelleys.org.uk
>> http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
>>
> 
> 
> 
> _______________________________________________
> Dnsmasq-discuss mailing list
> Dnsmasq-discuss@lists.thekelleys.org.uk
> http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
> 


Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss

Reply via email to