I've worked through the patch, and been inspired to clean up a few long-standing nasty bits. This has the consequence that the mechanisms which were added to enable storage of DNSKEY and DS RRtypes during the the DNSSEC campaign are now much more general, and I've used them to implement SRV caching. The new code is therefore all mine, as are any bugs, but the net effect is the same as Jeremy's (I hope).
I didn't implement a config switch to disable caching of SRV records, because I can't conceive of a situation where such would be necessary. Code is in the git repo now, and we're eating the new dog food here. Please test away. Cheers, Simon. On 20/12/2018 23:20, Jeremy Allison wrote: > On 12/20/2018 03:11 PM, Simon Kelley wrote: >> This is worth having for the removal of the archaic 16-bit limit on the >> flags field in a cache record alone. I've been meaning to tackle that >> for some time. >> >> This time of year either frees up lots of time for coding, or yields >> none at all, and for me it's the later, but I will go through this and >> merge it in the new year. > > Oh thanks for the comments. I'm currently running this version > under valgrind (with a minor test hack to force negative > SRV records to explitly expire after 60 seconds to ensure > I'm going through the cache expire code paths) and it seems > robust so far. > > There are some people in the ChromeOS Teams also looking > at this, although as it's holiday time here in the US it > might not get fully examined until Jan. If anyone finds > any more errors with it under test I'll let you know > and update it. > > Cheers & thanks and Merry Christmas / Happy Holidays ! > > Jeremy. >
Description: OpenPGP digital signature
_______________________________________________ Dnsmasq-discuss mailing list Dnsmasqfirstname.lastname@example.org http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss