On 13/08/2019 06:39, Geert Stappers wrote: > On Mon, Aug 12, 2019 at 05:31:05PM -0700, Tomasz Szajner wrote: >> Hi, >> >> It looks like the dhcp_lease_time utility is not working anymore >> (after I upgraded to version 2.80). I tracked it down to commit >> 2b38e382, in the file contrib/lease-tools/dhcp_lease_time.c (when I >> revert the change in this file, the utility works as expected). My >> guess is that the author forgot to reverse the "greater-than" symbol >> when multiplying both sides of the equation by -1, although I'm not >> sure what the intent of the change was. > > | $ git log 2b38e382...2b38e382~1 > | commit 2b38e3823b12ab13f86c3a44648de436daadb1f6 > | Author: Petr Men?ï¿½k <pemen...@redhat.com> > | Date: Fri Aug 17 10:20:05 2018 +0200 > | > | Minor improvements in lease-tools > | > | Limit max interface name to fit into buffer. > | Make sure pointer have to be always positive. > | Close socket after received reply. > > >> Appreciate any help. > > I think it is okay to send in a patch that reverts the breaking change.
No need send a patch. Thanks for the report: I just committed the fix. Sorry for the breakage. Cheers, Simon. > > > FWIW I myself have no use case for the dhcp_lease_time utility. > > > Groeten > Geert Stappers > _______________________________________________ Dnsmasq-discuss mailing list Dnsmasqemail@example.com http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss