On Sat, Sep 07, 2019 at 09:25:25AM -0700, Shota Hino wrote:
> On Sat, Sep 7, 2019 at 8:11 AM Geert Stappers <stapp...@stappers.nl> wrote:
> > On Sat, Sep 07, 2019 at 10:41:34AM +0200, Dominik wrote:
> > > On Fri, 2019-09-06 at 22:09 -0700, Shota Hino wrote:
> > > > It seems the use of tabs are not consistent.
> > > > On some IDE, the lines are misaligned and very difficult to read.
> > > >
> > > > Could you please run code formatter?
> > > >
> > > Set your tab width to 8. With this setting, I'm not seeing
> > > inconsistencies in the dnsmasq codebase.
> >
> >         :-)
> >
> >
> > The very same size of 8 characters for tab is documented
> > in the coding style of the Linux kernel.
> >
> > With
> >   wget
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/Documentation/process/coding-style.rst
> > we could (and should) add coding style definition to this project.
> >
> > Main reason is ending discussion on coding style is
> > to get more time on discussion how and where to improve Dnsmasq.
> >
>
> Whatever the width of the tab is, converting all tabs to whitespaces (or
> the other way around) would be better.
> If code formatting was forced at the time of each commit, there would be no
> need for anybody to set the tab width on their editor.
> Consistent coding style will help more developers in the future.

Yes.

First the pain of the fight tabs versus N-spaces.
And because humans tend to avoid fight and pain, nothing will happen.

Please proof me wrong (on "nothing will happen")


Groeten
Geert Stappers
-- 
Leven en laten leven

_______________________________________________
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss

Reply via email to