On 20/10/2019 18:19, Dominik DL6ER wrote: > Dear mailing list, > > The proposed patch ensures that the DHCPv6 IAID is of unsigned type. > This is entirely uncritical, however, as the variable is already now > interpreted and handled as being of unsigned type in > * lease.c:read_leases(), > * helper.c:create_helper(), > * dbus.c:dbus_add_lease(), and > * outpacket.c:put_opt6_long(), > its definition should reflect this to avoid inconsistencies. > > RFC3315 (section 22.4) confirms that the IAID is a 4 bytes long > unsigned integer. > The only operations on IAID other the comparison are to print it as a number in the lease file and some logs. That's already done as unsigned.
Patch applied as tidy up, with no expectation of functional changes. Simon. _______________________________________________ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss