On 17/02/2020 21:10, Geert Stappers wrote: > From: Geert Stappers <stapp...@stappers.nl> > > bld/get-version yields UNKNOWN in case no tarball version > or no git commit information is found. > > That UNKNOWN does scare those who are not familiar > with compling / building source code themself. > > Replaced the scary string with HOMEMADE > > Reported-by: Abhishek Patti <abhishek.pa...@gmail.com> > --- > bld/get-version | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bld/get-version b/bld/get-version > index e472aab..71d92d5 100755 > --- a/bld/get-version > +++ b/bld/get-version > @@ -23,7 +23,7 @@ if which git >/dev/null 2>&1 && \ > git describe | sed 's/^v//' > elif grep '\$Format:%d\$' $1/VERSION >/dev/null 2>&1; then > # unsubstituted VERSION, but no git available. > - echo UNKNOWN > + echo HOMEMADE > else > vers=`cat $1/VERSION | sed 's/[(), ]/,/ g' | tr ',' '\n' | grep ^v[0-9]` > >
I appreciate the thought, but is HOMEMADE more, or less likely to cause confusion. At least UNKNOWN is always true, whilst a binary reporting HOMEMADE may not be homemade at all. Cheers, Simon. _______________________________________________ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss