I'm inclined not to take these, on the grounds that complicated preprocessor stuff is a greater evil than false-positive warnings on unusual platforms for build configurations.
Simon. On 10/03/2020 10:25, Kevin 'ldir' Darbyshire-Bryant wrote: > Hi Simon, > > Feel free to throw these patches away! Prompted by the recent unused var > warning fixes when building on macos, I pondered if the warning suppression > was a bit too global. Some warnings are prompted by not including some code > (e.g. DHCPV6 vs no DHCPV6) and I wondered if the warning suppression should > be made (inverse) conditional. It means that if some future change genuinely > ends up with us not using a variable we will get a warning. > > Probably done at the same time as the whitespace cleanup, if at all :-) > > Cheers, > > Kevin D-B > > gpg: 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A > > > _______________________________________________ > Dnsmasq-discuss mailing list > Dnsmasqfirstname.lastname@example.org > http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss > _______________________________________________ Dnsmasq-discuss mailing list Dnsmasqemail@example.com http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss