On Fri, 13 Jan 2023, wkitt...@gmail.com wrote:

I'm not 100% happy with the patch, but I hope to be able to submit it tomorrow to get some suggestions and feedback.
Did you forget to attach your patch(es) or sent them off-list? I don’t see any attachments on this thread.
i'm not peter but look to the next day (Jan 5th) for the thread with
"[RFC PATCH] Add support for blocking A or AAAA queries per domain"

Correct; as mentioned I had hoped to publish it the following day.

That being said, after looking a little further into the problem, I've realized that an NXDOMAIN response is not really the proper behavior in this situation. It would be better to send a NODATA response, otherwise downstream servers may decide to cache the whole domain as nonexistent instead of only the AAAA record. It's probably as simple as changing the "rc = F_NXDOMAIN" line to "rc = F_NOERR" in my patch, but I haven't had a chance to try it out properly yet.

--
Peter Tirsek
_______________________________________________
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss

Reply via email to