On 29/12/2024 23:04, Matthias Andree via Dnsmasq-discuss wrote:
I think the previous RR_IMDATALEN expression is fine as long as you #include <stddef.h> before its first use, and as along as you won't coin your own version of offsetof, of which I don't know a conforming/portable way.
dnsmasq.h ~includes <stddef.h>, so no problem there.
The next thing you'll be missing is a _Static_assert to ensure sizeof(data) <= 16. Which isn't C99. :-)
I need a policy on supported C standards then :)
Could you also push the v2.91test3 tag to the public Git? Its HEAD is at 7c348a0, there is also a test3 tarball, but no Git tag, and my patches still apply on top of it, so it's older, my guess is 3ac11cd.
I don't know what happened there. The 2.91test3 tarball includes a commit and tag which aren't in the public repo, but the tarball is generated from a trigger when the public repo is updated. Unfortunately the local tree I pushed to do this is on a machine which is 350km away from me and switched off.
I've reapplied the missing patch from the tarball and tagged v2.91test4, to avoid inconsistencies.
Cheers, Simon.
Thanks in adavance. _______________________________________________ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss
_______________________________________________ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss
