Hello...

Please CC me on replies as I am not subscribed, thank you.

I am the co-maintainer of the Debian package of dnspython. A user forwarded me 
the attached patch (just rediffed against 1.3.5, as the current Debian 
version is 1.3.4).

It seems that in dns/resolver.py in function query() the nameservers are 
queried, but even in the event of a useful response dnspython uses the "don't 
pound the nameservers" wait.

The attached patch fixes this by breaking out of the while loop, if response 
"is not None" before executing the wait.

I am not quite sure, whether this actually is the right way to fix the 
problem, or if there actually is a problem, but the patch makes sense to me, 
so I forward it here.

Patrick
--- dns/resolver.py.orig	2006-03-14 19:01:58.471461560 +0100
+++ dns/resolver.py	2006-03-14 19:21:28.295621256 +0100
@@ -554,6 +554,8 @@
                     if rcode != dns.rcode.SERVFAIL:
                         nameservers.remove(nameserver)
                     response = None
+                if response is not None:
+                    break
                 #
                 # All nameservers failed!
                 #

Attachment: pgp1M8reE3TVx.pgp
Description: PGP signature

_______________________________________________
dnspython-bugs mailing list
[email protected]
http://woof.play-bow.org/mailman/listinfo/dnspython-bugs

Reply via email to