Hi (I supposed this is mostly targeted at Bill),

While reading Tim Berners Lee's Principles of Design, I came to remember one thing related to this site: why are we using POST on the search script? According to good practice, the search has no side-effects, so it should be using GET.

So in the case noone objects, I suggest this patch (hope it doesn't wrap incorrectly):

Index: tmpl/custom/html/search
===================================================================
RCS file: /home/cvspublic/modperl-docs/tmpl/custom/html/search,v
retrieving revision 1.21
diff -u -r1.21 search
--- tmpl/custom/html/search 24 Apr 2002 04:15:27 -0000 1.21
+++ tmpl/custom/html/search 24 Apr 2002 21:17:33 -0000
@@ -45,7 +45,7 @@
<td class="menu-border"><br></td>
<td class="non-sel-bg" align="center">
<div class="nonselectedmenuitem">
- <form method="post" action="[% doc.dir.abs_doc_root %]/search/swish.cgi" enctype="application/x-www-form-urlencoded" name="site_search_form">
+ <form method="GET" action="[% doc.dir.abs_doc_root %]/search/swish.cgi" enctype="application/x-www-form-urlencoded" name="site_search_form">
[% PROCESS search_widget %]
</form>
</div>
Index: tmpl/custom/html/search_field
===================================================================
RCS file: /home/cvspublic/modperl-docs/tmpl/custom/html/search_field,v
retrieving revision 1.1
diff -u -r1.1 search_field
--- tmpl/custom/html/search_field 19 Apr 2002 19:47:36 -0000 1.1
+++ tmpl/custom/html/search_field 24 Apr 2002 21:17:33 -0000
@@ -8,7 +8,7 @@


 [% USE CGI %]

- <form method="post" action="[% doc.dir.abs_doc_root %]/search/swish.cgi" enctype="application/x-www-form-urlencoded" name="site_search_form">
+ <form method="GET" action="[% doc.dir.abs_doc_root %]/search/swish.cgi" enctype="application/x-www-form-urlencoded" name="site_search_form">
[%
IF doc.meta.link == 'search/searchresults.html';
PROCESS results_search_widget;




--
Per Einar Ellefsen
[EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to