Hi Brian,

Brian Cameron wrote:
>
> Simon:
>
>> Because man pages in GPM tarball are in Debian system format, I update
>> them for Solaris. Attach man page for 3 applications.
>>
>> Please review or comment. 
>
> - I think the DESCRIPTION could explain more about what each program
>   does.  A description like "gnome-power-statistics is the gui
>   program for the gnome power management infrastructure." just doesn't
>   tell me much about this program.  Likewise the description for
>   gnome-power-preferences doesn't tell me much about what preferences
>   I can change.
>

I'll try to add more info there.

> - Are there other power manager related kernel programs that should
>   be mentioned in SEE ALSO?

I guess it's unnecessary. Among these executables, only 
gnome-power-manager depends on HAL layer.  So far they don't call kernel 
PM programs or use their configuration files. Additionally, the features 
introduced by GPM is totally new for Solaris, i.e, there's no conflict 
of GPM and known Solaris PM features. But in the future, once GPM is 
extended to current Solaris PM features, e.g, replacing configuration 
tool "dtpower",  we have to explain more.

>
> One thing I notice about these manpages is that your <variablelist> are
> not making good use of the termlength element.  Note this:
>
> ---
>
>      --help                          Show summary of options.
>
>      --verbose                       Show extra debugging.
>
>      --no-daemon                     Do not  detach  gnome-power-
>                                      manager  into the background
>                                      so that error messages  will
>                                      be displayed on console.
>
>      --debug                         Only show specific debugging
>                                      options. Useful for develop-
>                                      ers only.
>
> ---
>
> The spacing is a little ugly because there is a lot of white
> space between the arguments and the explanation.  Note that in
> the variablelist tag, you can specify the termlength element
> to control the spacing,  Try some of these:
>
>    <variablelist termlength="wide">
>    <variablelist termlength="narrow">
>    <variablelist termlength="xtranarrow">
>    <variablelist termlength="medium">
>    <variablelist termlength="xtranarrow">
>    <variablelist termlength="fullscreen">
>
> See which looks best.  I think the FILES sections are using an
> especially bad termlength value.

Thanks for your suggestion. Will update this.

>
> I also agree with Alan that there is no need for two trivial examples.
> Just have one trivial example.
Will keep only one.

-Simon



Reply via email to