On Fri, 26 Jul 2002, David Shane Holden wrote: > The attatched version of common.xsl includes my posted changes from earlier > and has been cleaned up for readability. My gawd that was one ugly file. > > I'm attaching the whole file becaues the diff was 6k bigger than the > original.
That looks like really good work, but I have to -1 (reject) that patch for now. The problem is that it combines substantive and style changes in a way that makes it impossible to see what has actually changed. I know that I have also done the same myself in the past, so it is not really your fault. But a quick try at merging your new common.xsl shows that it is missing at least one change from the last few days (relative-path vs relativepath). Since I'm not sure what else has changed, could you please update to the latest version and make your changes from there, and then submit them as two patches: one that has the substantive changes and one that fixes the style stuff. Thanks again, and sorry for the trouble. Joshua. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
