On Mon, 26 Jul 2004, Hiroaki KAWAI wrote:

Totally new translations should be reviewed once,
as was somethimes mentioned on this list, "review then commit."
IMHO, the modification or update of the translation may
be allowed in "commit then review" order.

And, actually, it is difficult to have every translation
updates be reviewed with our limited resource. :-(


Yoshiki Hayashi <[EMAIL PROTECTED]> wrote:
Joshua Slive <[EMAIL PROTECTED]> writes:
Just a reminder: all translations should include a "reviewed by" comment
in the commit message so that we know that it was properly reviewed.

Can we be a little bit lax about translations especially when there are more than one committers?

I've always leaned towards the more relaxed side of review standards on translations, but our concensus policy has always been to have reviews on anything non-english.


I'm personally willing to see commit-then-review on small changes, as long as the two of you promise to watch the commits and to inform us if you ever stop watching the commits.

Joshua.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to