Hi Mike, no need to apologize! Anybody is welcome to work on docs, these are weird encoding issues, we'll sort them out, it is just a matter of deciding how to proceed :)
For buildbot, I am still not sure if it is doable or not, I'll follow up with Humbedooh during the next days but I am pretty sure it might take a while before we have it ready to test. Luca Il giorno dom 9 feb 2020 alle ore 16:34 Mike Rumph <[email protected]> ha scritto: > > Hello all, > > Like mentioned before to Eric, I apologize for committing the massive changes > resulting from switching to Java 11 without first discussing it on docs (I > just didn't understand the issues at that time). > One thing is fairly certain is that we wouldn't want to keep switching back > and forth between Java 8 and Java 11. > Which version does the buildbot use (probably Java 8). > I took the approach of just letting the buildbot generate the .html files > with my commit for 2.4 branch. > (Because I didn't want to do more damage until the issue is settled.) > > One solution that is used by some of the files is to switch to utf8. > Notice that some of the files end in .html.<language> while others in > html.<language>.utf8. > > Maybe there is also away to configure Java 11 to behave in a different way. > > > > On Sun, Feb 9, 2020 at 7:13 AM Luca Toscano <[email protected]> wrote: >> >> Hi Lucien, >> >> I am using java 8, not 11 :) >> >> What Christophe suggested seems right, namely that Mike R. committed >> with r1873229 new versions of files replacing UTF-8 chars with >> something different. For example, in my current case the following >> diff shows up after building: >> >> docs/manual/rewrite/flags.html.en >> >> -<a href="../fr/rewrite/flags.html" hreflang="fr" rel="alternate" >> title="Français"> fr </a></p> >> +<a href="../fr/rewrite/flags.html" hreflang="fr" rel="alternate" >> title="Fran�ais"> fr </a></p> >> >> If you check r1873229 you'll see the following: >> >> http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/manual/rewrite/flags.html.en?limit_changes=0&r1=1873229&r2=1873228&pathrev=1873229 >> >> -<a href="../fr/rewrite/flags.html" hreflang="fr" rel="alternate" >> title="Fran�ais"> fr </a></p> >> +<a href="../fr/rewrite/flags.html" hreflang="fr" rel="alternate" >> title="Français"> fr </a></p> >> >> So my build with Java 8 is basically reverting what Mike did after >> building with Java 11. Not sure now what is the best path, or if the >> is a workaround, this is why I asked in the last email what do we want >> to do. Maybe just using Java 11 and stick with it? >> >> Long term solution, in my opinion, is what Humbedooh suggested in >> #httpd-dev on Freenode, namely commit .xml files and let buildbot to >> automagically create html files (so we'll have only one way to build >> things, on one platform). >> >> Luca >> >> Il giorno dom 9 feb 2020 alle ore 15:04 Lucien Gentis >> <[email protected]> ha scritto: >> > >> > Hi, >> > >> > I cannot reproduce these diff here. >> > >> > I also have java 11 ; java --version gives : >> > >> > openjdk 11.0.6 2020-01-14 >> > OpenJDK Runtime Environment (build 11.0.6+10-post-Debian-1deb10u1) >> > OpenJDK 64-Bit Server VM (build 11.0.6+10-post-Debian-1deb10u1, mixed >> > mode, sharing) >> > >> > I have downloaded trunk repos in a clean working directory and launched >> > "build.sh on it, >> > >> > and docs/manual/new_features_2_4.html.en still contains : >> > >> > <p><span>Available Languages: </span><a >> > href="./en/new_features_2_4.html" title="English"> en </a> | >> > <a href="./es/new_features_2_4.html" hreflang="es" rel="alternate" >> > title="Español"> es </a> | >> > >> > where non ASCII characters are replaced by there html entities and >> > "Español"> is not replaced by "Espa�ol"> >> > >> > Did you modify some file in manual/style directory ? >> > >> > Le 08/02/2020 à 19:33, Luca Toscano a écrit : >> > > Hi Lucien, >> > > >> > > some of the files: >> > > >> > > docs/manual/rewrite/flags.html.en >> > > docs/manual/new_features_2_4.html.en >> > > docs/manual/mod/mod_systemd.html.en >> > > >> > > Il giorno sab 8 feb 2020 alle ore 18:29 Lucien Gentis >> > > <[email protected]> ha scritto: >> > >> In what file do you get the diff : >> > >> >> > >> -<a href="./es/sitemap.html" hreflang="es" rel="alternate" >> > >> title="Español"> es </a> | >> > >> -<a href="./fr/sitemap.html" hreflang="fr" rel="alternate" >> > >> title="Français"> fr </a> | >> > >> +<a href="./es/sitemap.html" hreflang="es" rel="alternate" >> > >> title="Espa�ol"> es </a> | >> > >> +<a href="./fr/sitemap.html" hreflang="fr" rel="alternate" >> > >> title="Fran�ais"> fr </a> | >> > >> >> > >> Le 08/02/2020 à 17:55, Luca Toscano a écrit : >> > >>> Hi Mike, >> > >>> >> > >>> thanks for following up. I noticed the thread but I am using java 8, >> > >>> and I haven't had any problems with it in the past, so I didn't try to >> > >>> remove the Xbootclasspath parameter. I just did now but the problem >> > >>> persists, so it must be something else :( >> > >>> >> > >>> Luca >> > >>> >> > >>> Il giorno sab 8 feb 2020 alle ore 17:10 Mike Rumph >> > >>> <[email protected]> ha scritto: >> > >>>> I should also mention that this difference does not appear in the >> > >>>> .html.utf8 files. >> > >>>> >> > >>>> On Sat, Feb 8, 2020 at 7:59 AM Mike Rumph <[email protected]> wrote: >> > >>>>> Hello Luca, >> > >>>>> >> > >>>>> See the previous thread related to commit r1873229: >> > >>>>> - >> > >>>>> http://mail-archives.apache.org/mod_mbox/httpd-docs/202001.mbox/browser >> > >>>>> >> > >>>>> I caused a problem or solved one depending on one's perspective. >> > >>>>> I created a massive change by running ./build.sh with Java 11. >> > >>>>> (Was it right or wrong to commit those changes is up to debate.) >> > >>>>> To make ./build.sh work I needed to modify the script to remove the >> > >>>>> -Xbootclasspath/p:"$LOCALCLASSPATH" option. >> > >>>>> There is another thread for this also in the above link. >> > >>>>> That option is not in Java versions after Java 8. >> > >>>>> So I think the change to use encodings was a side effect of moving >> > >>>>> to Java 11. >> > >>>>> What version of Java are you using? >> > >>>>> >> > >>>>> BTW. I committed the Java 11 changes to the trunk branch but not to >> > >>>>> the 2.4 branch. >> > >>>>> >> > >>>>> On Sat, Feb 8, 2020 at 2:20 AM Luca Toscano <[email protected]> >> > >>>>> wrote: >> > >>>>>> Hi everybody, >> > >>>>>> >> > >>>>>> apologies in advance for my question, I haven't followed completely >> > >>>>>> all the past threads. I am trying to add some docs for mod_systemd, >> > >>>>>> and while building the trunk's docs I keep getting a diff like: >> > >>>>>> >> > >>>>>> -<a href="./es/sitemap.html" hreflang="es" rel="alternate" >> > >>>>>> title="Español"> es </a> | >> > >>>>>> -<a href="./fr/sitemap.html" hreflang="fr" rel="alternate" >> > >>>>>> title="Français"> fr </a> | >> > >>>>>> +<a href="./es/sitemap.html" hreflang="es" rel="alternate" >> > >>>>>> title="Espa�ol"> es </a> | >> > >>>>>> +<a href="./fr/sitemap.html" hreflang="fr" rel="alternate" >> > >>>>>> title="Fran�ais"> fr </a> | >> > >>>>>> >> > >>>>>> To build, I do the usual ./build.sh in docs/manual/build. I am aware >> > >>>>>> that there are issues with char encodings from a quick glance on >> > >>>>>> older >> > >>>>>> threads, but I am wondering if there is a current best practice in >> > >>>>>> how >> > >>>>>> to build docs to avoid committing weird changes :) >> > >>>>>> >> > >>>>>> Thanks in advance, >> > >>>>>> >> > >>>>>> Luca >> > >>>>>> >> > >>>>>> --------------------------------------------------------------------- >> > >>>>>> To unsubscribe, e-mail: [email protected] >> > >>>>>> For additional commands, e-mail: [email protected] >> > >>>>>> >> > >>> --------------------------------------------------------------------- >> > >>> To unsubscribe, e-mail: [email protected] >> > >>> For additional commands, e-mail: [email protected] >> > >>> >> > >> --------------------------------------------------------------------- >> > >> To unsubscribe, e-mail: [email protected] >> > >> For additional commands, e-mail: [email protected] >> > >> >> > > --------------------------------------------------------------------- >> > > To unsubscribe, e-mail: [email protected] >> > > For additional commands, e-mail: [email protected] >> > > >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [email protected] >> > For additional commands, e-mail: [email protected] >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
