Hi Emanuele, On 2 February 2015 at 00:17, Emanuele Minotto <[email protected]> wrote:
> Hi all, > I'm trying to contribute to a doctrine project (doctrine/KeyValueStore) > but I have some questions before starting. > I was reading this: > http://www.doctrine-project.org/contribute.html#project-dependencies > > 1. *"Project dependencies between Doctrine projects are handled > through git submodules."* > Why not Composer? > > That's just outdated information. I think it just needs to be updated or entirely rewritten. > > 1. *"The code of the particular Doctrine project you have cloned is > located under **lib/Doctrine**."* > Working with PSR-4 this is not a requirement. Is it a decision, a good > practice or a requirement? > > We generally accept PSR-0 only, as it is much less confusing than PSR-4 when browsing the directory tree. We also are one of the few FIG members that voted against PSR-4 due to its confusing prefixing/path matching syntax. An exception are the bundles: since the Symfony bundle system actually does have some assumptions about where resources are located, we preferred using PSR-4 for those, as it actually makes things simpler in this case. > > 1. (if PSR-4 is permitted) I use the following directory structure, is > it permitted and a good/bad practice (please don't kill me if it's a too > bad practice hehe)? > > directories and files > / > - /Tests > -- LibraryTest.php > - Library.php > > in the composer.json (located under the same path of Library.php) > { > "autoload": { > "psr-4": { > "Vendor\\": "." > } > } > } > > and in phpunit.xml.dist (located under the same path of Library.php) > <phpunit bootstrap="vendor/autoload.php"> > <testsuites> > <testsuite name="Library Test Suite"> > <directory>./Tests/</directory> > </testsuite> > </testsuites> > </phpunit> > > -- > Please look at the ORM structure if you need a reference: we pretty much consider Doctrine ORM as the reference implementation for all other mapper projects in the organization. Marco Pivetta http://twitter.com/Ocramius http://ocramius.github.com/ -- You received this message because you are subscribed to the Google Groups "doctrine-user" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/doctrine-user. For more options, visit https://groups.google.com/d/optout.
