Thanks for following up! I think the discussion on the PR will lead to documenting a BC break, but it is good that you documented and covered this with tests!
Marco Pivetta http://twitter.com/Ocramius http://ocramius.github.com/ On 31 March 2016 at 16:46, Steve Clay <[email protected]> wrote: > https://github.com/doctrine/dbal/pull/2346 has the tests. Let me know if > this is the desired behavior. > > Steve > > > > On 3/31/16 8:11 AM, Steve Clay wrote: > >> I assume I should update the code samples to not pass in leading colons. >> >> Should setParameter(':name', 'foo') and setParameters([':name' => 'foo']) >> silently remove colons from keys? >> >> Should getParameter(':name') silently return the value for "name"? >> >> Steve >> >> >> On 3/31/16 6:57 AM, Marco Pivetta wrote: >> >>> >>> "dcValue1" is indeed correct, as that's the name of the parameter, while >>> ":" is just a marker, like "$" in php. You mentioned a case where binding >>> to ":test" (colon included) works: I am worried about that one instead. >>> >>> >>> >> > -- > You received this message because you are subscribed to the Google Groups > "doctrine-user" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at https://groups.google.com/group/doctrine-user. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "doctrine-user" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/doctrine-user. For more options, visit https://groups.google.com/d/optout.
