Johan Hake wrote: > On Saturday 16 May 2009 21:21:46 Garth N. Wells wrote: >> The Python demos need to be looked at now - I get a seg fault for Python >> demos but I don't know what the problem is. > > I have fixed this now. I haven't checked all python demos. The bug was > introduced in an esthetic (I think) cleanup of DofMap.h, where the reference > construct where moved before the shared_ptr constructor. Swig encoutners this > and choose this instead of the right shared_ptr one. > > I have no ignored all reference constructors in, DofMap, FiniteElement and > FunctionSpace, so this will not happen again. Are these used anywhere (the > reference constructors) or can we remove them from the interface? >
They're there to provide a simple interface for constructing objects, and partly to simplify wrapping for the Python interface (before wrapping shared_ptr was sorted out). Since construction of DofMaps will be done primarily via the automatically generated FunctionSpace wrappers, I think we can get rid of the reference constructors. Anyone who creates a DofMap directly will be a more advanced user and should be able to understand the shared_ptr syntax. Garth > I recall that we kept them because of the python interface, and now they only > cause havoc, for the python interface. > > Johan > >> Garth >> >> DOLFIN wrote: >>> One or more new changesets pushed to the primary dolfin repository. >>> A short summary of the last three changesets is included below. >>> >>> changeset: 6166:d992f50fe3ffffec2d761755d467de53776c723e >>> tag: tip >>> user: "Garth N. Wells <[email protected]>" >>> date: Sat May 16 20:07:37 2009 +0100 >>> files: demo/pde/equality/cpp/main.cpp >>> demo/pde/functional/cpp/main.cpp demo/pde/mixed-poisson/cpp/main.cpp >>> demo/pde/nonlinear-poisson/cpp/main.cpp demo/pde/periodic/cpp/main.cpp >>> demo/pde/poisson1D/cpp/main.cpp demo/pde/stokes/stabilized/cpp/main.cpp >>> demo/pde/sym-dirichlet-bc/cpp/main.cpp demo/pde/waveguide/cpp/main.cpp >>> description: >>> Get all C++ demos to compile again. >>> >>> >>> changeset: 6165:4feb979b455e6ad12781db4e19c3c4fd5c13355f >>> user: Anders Logg <[email protected]> >>> date: Sat May 16 20:37:37 2009 +0200 >>> files: dolfin/function/FunctionSpace.h >>> description: >>> Make destructor of FunctionSpace virtual >>> >>> >>> changeset: 6164:c560bfcc136e867c45bbe8890d9c7ceb9c723ee8 >>> user: "Garth N. Wells <[email protected]>" >>> date: Sat May 16 16:18:09 2009 +0100 >>> files: demo/function/eval/cpp/main.cpp >>> demo/pde/cahn-hilliard/cpp/main.cpp >>> demo/pde/dg/advection-diffusion/cpp/main.cpp >>> demo/pde/dg/poisson/cpp/main.cpp description: >>> Fix some demos. >>> >>> ---------------------------------------------------------------------- >>> For more details, visit http://www.fenics.org/hg/dolfin >>> _______________________________________________ >>> DOLFIN-dev mailing list >>> [email protected] >>> http://www.fenics.org/mailman/listinfo/dolfin-dev >> _______________________________________________ >> DOLFIN-dev mailing list >> [email protected] >> http://www.fenics.org/mailman/listinfo/dolfin-dev > > _______________________________________________ DOLFIN-dev mailing list [email protected] http://www.fenics.org/mailman/listinfo/dolfin-dev
