On Mon, Oct 05, 2009 at 02:50:37PM +0100, Garth N. Wells wrote: > > > Anders Logg wrote: > > On Mon, Oct 05, 2009 at 02:43:23PM +0100, Garth N. Wells wrote: > >> > >> DOLFIN wrote: > >>> One or more new changesets pushed to the primary dolfin repository. > >>> A short summary of the last three changesets is included below. > >>> > >>> changeset: 7257:fe7e2da1c7d8 > >>> tag: tip > >>> user: Anders Logg <l...@simula.no> > >>> date: Mon Oct 05 14:25:22 2009 +0200 > >>> files: dolfin/function/Constant.cpp dolfin/function/Constant.h > >>> description: > >>> Add optional constructors for Constant deriving geometric_dimension from > >>> the mesh. > >>> > >> In Constant, we should probably pass the std::vectors by value rather > >> than reference to be consustent with the constructor > >> > >> Constant(uint geometric_dimension, double value); > >> > >> This will also prevent any out-of-scope memory issues. > > > > They will be copied anyway so there are no memory issues. > > > > I didn't scroll down to the private data . . . > > > But we could pass by value to be explicit about it and since it's > > probably a very small vector anyway. Is that what you suggest? > > > > Yes.
ok, done. -- Anders > Garth > > >> Garth > >> > >>> changeset: 7256:8b586d30fd58 > >>> user: Anders Logg <l...@simula.no> > >>> date: Mon Oct 05 14:20:06 2009 +0200 > >>> files: demo/pde/poisson/cpp/main.cpp dolfin/function/Constant.h > >>> dolfin/mf/ConvectionMatrix.h dolfin/mf/LoadVector.h > >>> dolfin/mf/MassMatrix.h dolfin/mf/StiffnessMatrix.h > >>> description: > >>> Fix compilation errors not visible until compiling demos. > >>> > >>> > >>> changeset: 7255:c03da78a4dca > >>> parent: 7254:bbe59aaee1de > >>> parent: 7253:4142d5b1e735 > >>> user: Anders Logg <l...@simula.no> > >>> date: Mon Oct 05 14:14:54 2009 +0200 > >>> description: > >>> merge > >>> > >>> ---------------------------------------------------------------------- > >>> For more details, visit http://www.fenics.org/hg/dolfin > >>> _______________________________________________ > >>> DOLFIN-dev mailing list > >>> DOLFIN-dev@fenics.org > >>> http://www.fenics.org/mailman/listinfo/dolfin-dev > >> _______________________________________________ > >> DOLFIN-dev mailing list > >> DOLFIN-dev@fenics.org > >> http://www.fenics.org/mailman/listinfo/dolfin-dev > >> > >> ------------------------------------------------------------------------ > >> > >> _______________________________________________ > >> DOLFIN-dev mailing list > >> DOLFIN-dev@fenics.org > >> http://www.fenics.org/mailman/listinfo/dolfin-dev > _______________________________________________ > DOLFIN-dev mailing list > DOLFIN-dev@fenics.org > http://www.fenics.org/mailman/listinfo/dolfin-dev
signature.asc
Description: Digital signature
_______________________________________________ DOLFIN-dev mailing list DOLFIN-dev@fenics.org http://www.fenics.org/mailman/listinfo/dolfin-dev
