On Mon, Aug 09, 2010 at 08:05:59PM +0200, Johannes Ring wrote: > On Mon, Aug 9, 2010 at 4:42 PM, Anders Logg <l...@simula.no> wrote: > > On Mon, Aug 09, 2010 at 04:39:44PM +0200, Johannes Ring wrote: > >> On Mon, Aug 9, 2010 at 4:21 PM, Anders Logg <l...@simula.no> wrote: > >> > Nice. Is the naming scheme part of CMake? For example > >> > > >> > cmake/DOLFINFindArmadillo.cmake > >> > > >> > Or would it be possible to name it > >> > > >> > cmake/FindArmadillo.cmake ? > >> > >> Yes, no problem. CMake already has lots of Find<package>.cmake files > >> like FindSWIG.cmake (see in /usr/share/cmake-2.8/Modules/ or similar). > >> The reason for the DOLFIN prefix was to separate the CMake Find*.cmake > >> files from the ones in DOLFIN, but this is surely not required. > > > > ok, I just found it a bit hard to read. > > > > Will the CMake Find<package> files be stored in the same directory as > > our Find<package> files? If not, I suggest we rename then and drop > > "DOLFIN". > > No, they won't be stored in the same directory. However, the problem > is that sometimes we want to extend the Find<package> that comes with > CMake, like I have done in cmake/DOLFINFindBoost.cmake. It is not a > good idea to have the same name (FindBoost.cmake) for both since > DOLFINFindBoost makes use of FindBoost. The way of adding the project > name as prefix is just something I picked up from another CMake based > project. Maybe there is a better way to deal with this?
I see. Would it work to have FindArmadillo.dolfin.cmake ? -- Anders
signature.asc
Description: Digital signature
_______________________________________________ Mailing list: https://launchpad.net/~dolfin Post to : dolfin@lists.launchpad.net Unsubscribe : https://launchpad.net/~dolfin More help : https://help.launchpad.net/ListHelp
