On Tue, 2010-08-10 at 16:49 +0100, Garth N. Wells wrote:
> On Tue, 2010-08-10 at 17:44 +0200, Anders Logg wrote:
> > On Tue, Aug 10, 2010 at 04:42:14PM +0100, Garth N. Wells wrote:
> > > On Tue, 2010-08-10 at 13:57 +0000, nore...@launchpad.net wrote:
> > > > ------------------------------------------------------------
> > > > revno: 4929
> > > > committer: Anders Logg <l...@simula.no>
> > > > branch nick: dolfin-dev
> > > > timestamp: Tue 2010-08-10 15:55:16 +0200
> > > > message:
> > > > Fix typo in UMFPACK configure script, works now.
> > >
> > >
> > > Are you sure? Doesn't look like the libs are being set.
> > >
> > > Garth
> >
> > I realized that a few minutes ago and tried a fix (adding
> > link_directories(${UMFPACK_LIBRARY})). It didn't work. Am I missing
> > something?
> >
>
> Christophe Prudhomme uses CMake for Life:
>
> https://ljkforge.imag.fr/scm/viewvc.php/life/trunk/?root=life
>
> Take a how it done there. Looks nice and tidy.
>
I was a bit quick with the keyboard above. ;)
Garth
> We shouldn't be setting things in FindFoo.cmake files. We should return
> variables and then set them. Here an extract from the CMakeList.txt file
> from Life:
>
> FIND_PACKAGE( PETSc )
> if ( PETSC_FOUND )
> SET(CMAKE_REQUIRED_INCLUDES
> "${PETSC_INCLUDES};${CMAKE_REQUIRED_INCLUDES}")
> SET(LIFE_LIBRARIES ${PETSC_LIBRARIES} ${LIFE_LIBRARIES})
> endif( PETSC_FOUND )
>
> Garth
>
> > --
> > Anders
> >
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dolfin
> Post to : dolfin@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~dolfin
> More help : https://help.launchpad.net/ListHelp
_______________________________________________
Mailing list: https://launchpad.net/~dolfin
Post to : dolfin@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dolfin
More help : https://help.launchpad.net/ListHelp
