On Thu, Sep 01, 2011 at 08:38:11AM -0700, Garth N. Wells wrote: > > > On 01/09/11 08:23, Anders Logg wrote: > > On Thu, Sep 01, 2011 at 08:13:53AM -0700, Garth N. Wells wrote: > >> > >> > >> On 01/09/11 08:06, Marie E. Rognes wrote: > >>> On 09/01/11 16:55, Garth N. Wells wrote: > >>>> The name of the function Hierarchical::fine should be changed. My first > >>>> reaction was that > >>>> > >>>> u.fine() > >>>> > >>>> should mean 'Hello, are you OK?' > >>>> > >>> > >>> *rofl* > >>> > >> > >> I had to google that. ;) > >> > >>>> The description of the class Hierarchical doesn't make any reference to > >>>> 'fineness'. It just describes a straight tree. A 'finest function' is > >>>> ambiguous, How can I define this on different meshes or with different > >>>> bases? > >>>> > >>>> If Hierarchical is a tree, then an allowable operation would be to > >>>> return a vector of leaves (just one leaf for a straight tree). Likewise, > >>>> 'Hierarchical::coarse' should be 'Hierarchical::root'. > >>>> > >>> > >>> I don't care about the name, give me something that you can > >>> agree upon, and I'll fix. > >>> > >> > >> It depends on what Hierarchical is meant to be. Will it always be > >> straight, or should it/will it also support a parent with multiple > >> children? > > > > I don't foresee any need for ever creating "non-straight" hierarchies. > > > > Then how about 'begin' and 'end', 'start' and 'end', or 'root' and > 'last'? (or some other combination). > > Since Hierarchical is a very general base class, it would probably be > useful add something to the function names to make clear that the > functions are related to the hierarchy. This would avoid possible > confusion with concepts specific to a particular subclass.
Sounds good, but I'm not sure about the names, perhaps root_object, leaf_object? -- Anders > Garth > > >> Garth > >> > >>>> Garth > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> On 01/09/11 05:10, Marie Rognes wrote: > >>>>> ** Changed in: dolfin > >>>>> Status: Confirmed => In Progress > >>>>> > >>>> > >>>> _______________________________________________ > >>>> Mailing list: https://launchpad.net/~dolfin > >>>> Post to : dolfin@lists.launchpad.net > >>>> Unsubscribe : https://launchpad.net/~dolfin > >>>> More help : https://help.launchpad.net/ListHelp > >>> > >>> > >>> _______________________________________________ > >>> Mailing list: https://launchpad.net/~dolfin > >>> Post to : dolfin@lists.launchpad.net > >>> Unsubscribe : https://launchpad.net/~dolfin > >>> More help : https://help.launchpad.net/ListHelp > >> > >> > >> _______________________________________________ > >> Mailing list: https://launchpad.net/~dolfin > >> Post to : dolfin@lists.launchpad.net > >> Unsubscribe : https://launchpad.net/~dolfin > >> More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~dolfin Post to : dolfin@lists.launchpad.net Unsubscribe : https://launchpad.net/~dolfin More help : https://help.launchpad.net/ListHelp
