On Sep 14, 2012 7:11 PM, "Anders Logg" <l...@simula.no> wrote: > > I think both solutions are acceptable. If we choose the > flag-in-makefile option, then better to look for a flag like "DO NOT > OVERWRITE". > > -- > Anders > > > On Fri, Sep 14, 2012 at 04:12:42PM +0200, Joachim Berdal Haga wrote: > > Any list-of-things needs maintenance.
Remembering to add a line in the cmake file is also maintenance. Not a big deal for me though. I see benefit with both solutions. The list approach is already used for example in generating swig interface and it give the devs a nice overview at one place. Johan > > > > But I'll do the exclusion list if you prefer. > > > > -j. > > > > > > On 14 September 2012 16:09, Johan Hake <hake....@gmail.com> wrote: > > > Why would that be less to maintain? Aren't we talking about 3 lines? > > > > > > Johan > > > > > > On 09/14/2012 04:01 PM, Joachim Berdal Haga wrote: > > >> Would it be acceptable to check the first line of the existing file > > >> (if any), and skip it if it doesn't say "automatically generated"? > > >> Less maintenance... > > >> > > >> -j. > > >> > > >> > > >> On 14 September 2012 15:50, Johan Hake <hake....@gmail.com> wrote: > > >>> I think providing hand made CMakeFiles for specific demos should be > > >>> allowed. > > >>> > > >>> Maybe you can introduce a list with excludes in generate-cmakefiles. > > >>> Something like > > >>> > > >>> excludes = ["qtplot"] > > >>> > > >>> and then something like: > > >>> > > >>> ... > > >>> if os.path.basename(root) in excludes: > > >>> continue > > >>> ... > > >>> > > >>> Johan > > >>> > > >>> On 09/14/2012 03:40 PM, Joachim Berdal Haga wrote: > > >>>> I have a demo that I'd like to put in demo/undocumented. It > > >>>> demonstrates embedding of the plot window in a qt application. > > >>>> > > >>>> It requires a custom CMakeLists.txt, but I'm concerned it will be > > >>>> overwritten by one that is automatically generated by > > >>>> cmake/scripts/generate-cmakefiles. > > >>>> > > >>>> Will this be a problem? > > >>>> > > >>>> -j. > > >>>> > > >>>> _______________________________________________ > > >>>> Mailing list: https://launchpad.net/~dolfin > > >>>> Post to : dolfin@lists.launchpad.net > > >>>> Unsubscribe : https://launchpad.net/~dolfin > > >>>> More help : https://help.launchpad.net/ListHelp > > >>>> > > >>> > > > > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~dolfin > > Post to : dolfin@lists.launchpad.net > > Unsubscribe : https://launchpad.net/~dolfin > > More help : https://help.launchpad.net/ListHelp
_______________________________________________ Mailing list: https://launchpad.net/~dolfin Post to : dolfin@lists.launchpad.net Unsubscribe : https://launchpad.net/~dolfin More help : https://help.launchpad.net/ListHelp
