+1 Be carefull, there is trigger id, path where to store doc, default template, and a lot of other things that are specific to each function. We must reproduce this into generic method.
2014-09-15 16:27 GMT+02:00 [Kreiz IT]Cédric GROSS <c.gr...@kreiz-it.fr>: > +1 J > > Cedric > > > > De : dolibarr-dev-bounces+c.gross=kreiz-it...@nongnu.org > [mailto:dolibarr-dev-bounces+c.gross=kreiz-it...@nongnu.org] De la part de > Maxime Kohlhaas > Envoyé : lundi 15 septembre 2014 15:40 > À : Posts about Dolibarr ERP & CRM development and coding > Objet : Re: [Dolibarr-dev] X_pdf_create > > > > Agreed, and I think this should be in the CommonObject class. > > And the method should be called within the class (by validate or update or > addline functions) and not in the xxx.php file in each case action = > 'addline', action = 'confirme_valid', ... > > > Bien cordialement, > > > > -- > Maxime Kohlhaas > Consultant associé > ATM Consulting > +33 6 33 42 92 43 > > > > 2014-09-15 12:49 GMT+02:00 Marcos García <marcos...@gmail.com>: > > Hi all: > > > > I've noticed that there are many functions called x_pdf_create > (expedition_pdf_create, ...) that are used to create documents of a > specified object. > > > > I was thinking that because this function depend on a given Object, why not > implementing them as a public function of the given class? We'll keep the > old functions for compatibility but I think moving the function with a > generic name like generateDocument or createDocument will be better than the > actual implementation. > > > > What do you think? > > > > Regards, > > > > Marcos García > > marcos...@gmail.com > > > _______________________________________________ > Dolibarr-dev mailing list > Dolibarr-dev@nongnu.org > https://lists.nongnu.org/mailman/listinfo/dolibarr-dev > > > > > _______________________________________________ > Dolibarr-dev mailing list > Dolibarr-dev@nongnu.org > https://lists.nongnu.org/mailman/listinfo/dolibarr-dev > -- Laurent Destailleur (alias Eldy) ------------------------------------------------------------------------------------ Social networks of my OpenSource projects: Dolibarr Google+: https://plus.google.com/+DolibarrOrg/ Dolibarr Facebook: https://www.facebook.com/dolibarr Dolibarr Twitter: http://www.twitter.com/dolibarr AWStats Google+: https://plus.google.com/+AWStatsOrgPoject/ AWStats Facebook: https://www.facebook.com/awstats.org AWStats Twitter: http://www.twitter.com/awstats_project _______________________________________________ Dolibarr-dev mailing list Dolibarr-dev@nongnu.org https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
