Hello,

I agree with you for the getObjectUrl function name.

BUT i really hope that the old getNomUrl function will still remains for _compatibility with all the external modules_ that use it !!!
(of course this old function should become just a call to the new one)

My two cents
Christophe

Le 13/10/2014 17:30, Marcos García a écrit :
Hi all:

Alexandre Spangaro (aspangaro) did a PR (https://github.com/Dolibarr/dolibarr/pull/1936#issuecomment-58801858) where some parts of the code got renamed and therefore translated to English.

I saw he translated getNomUrl function to getNameUrl, but then I thought a more appropiate name would be getObjectUrl, as we are geting the url of the object, not of the name.

What do you think?

Regards,

    *Marcos García*

    marcos...@gmail.com <mailto:marcos...@gmail.com>



_______________________________________________
Dolibarr-dev mailing list
Dolibarr-dev@nongnu.org
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev


--
Christophe Battarel
Responsable technique
sarl altairis
Informatique et Web en Grésivaudan
33 Grande Rue
38570 Goncelin
09 52 71 70 96 (appel local)
cont...@altairis.fr
http://www.altairis.fr

_______________________________________________
Dolibarr-dev mailing list
Dolibarr-dev@nongnu.org
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev

Répondre à