On Tue, Jun 23, 2009 at 9:35 AM, Bart Oldeman<bartolde...@users.sourceforge.net> wrote: > Hello Samuel, > > thanks for your changes! > > I think it's fine, and more correct to use exit() than _exit(). That > _exit has been there since ancient DOSEMU (I just checked 0.50pl1 from > 18 March 1994), I have no idea why. One place where _exit is necessary > is in the emergency double SIGSEGV case but that's explained in > sigsegv.c.
Ah. In that case, I guess I'll remove that comment ;-). > About the keyboard changes, I'm not sure either, need to study the code. Well, I was thinking maybe MODIFIER_VOID shouldn't have any bits in common with the other MODIFIER_ values, even though it shouldn't matter to the caller that valgrind was complaining about. What do you think? > Are you running valgrind with $_cpu_emu="fullsim" or otherwise? I was trying to run it with $_cpu_emu off on i386; this doesn't really work very well for my test of invoking DJGPP's "ls.exe": *something* seems to get into an infinite loop after valgrind fails to recognize an "lss" instruction and warns that it is about to give DOSEMU a SIGILL. I'm about to look into adding support to valgrind for that and any other instructions it doesn't recognize yet. ------------------------------------------------------------------------------ Are you an open source citizen? Join us for the Open Source Bridge conference! Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250. Need another reason to go? 24-hour hacker lounge. Register today! http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org _______________________________________________ Dosemu-devel mailing list Dosemu-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dosemu-devel
