On 11 December 2012 04:22, Stas Sergeev wrote:
> Grr, the licensing problems are turning into a technical problems,
> again...
> By the way, I thought the "unlicensed" code defaults to the main
> license of the project. At least I don't think I ever covered my
> contributions to other projects with some license, and there were
> no problems, even in linux kernel.
Yes, but here the problem is that MAME is not Open Source.
mamedev.org/devwiki/index.php/Is_MAME_Open_Source%3F
en.wikipedia.org/wiki/MAME
> Seems like you made it to work with both ymf262.c and dbopl.c.
> I guess that's for testing only?
Yes, just to check that dbopl.c works, then ymf262.c can be deleted.
> Also, a quick looks shows there are still some plusisms:
> ---
> +struct Handler : public Adlib::Handler {
> ---
> Does this even work?
it's commented out. I took dbopl.h and dbopl.c unmodified (as much as
possible, just needed to add two function definitions) from Chocolate
Doom.
> dbopl.c doesn't seem to have any of the above, at least on
> a quick glance I did. It still seems to be modelled around the
> old API of ymf262.c. So, while I can't comment on an implementation
> internals, for us it isn't going to be any better, if not worse. :)
The timer stuff is all in dbadlib.c, we could easily replace it
completely even without modifying dbopl.c.
But yes, dosbox used to have runtime selectable OPL (MAME, Ken
Silverman, or DOSBOX), and then they dropped the (oldest) MAME one, so
it's not surprising the API is similar.
Thanks for having a look,
Bart
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Dosemu-devel mailing list
Dosemu-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dosemu-devel
