On 05/06/2014 04:39 PM, Robert Nowotny wrote:
> I propose it would be good practice to write some logging in the default
> switch cases, to see the unexpected returnvalues in the errorlog.
>
> something like :
>
> ostream-lzma.c :
> -- Line 147 : i_unreached();
> ++ Line 147 : i_fatal("unexpected lzma errorcode when flushing : %s",
> ret);
>
> after that modification the errorlog shows :
>
> May 6 14:03:05 vm-imap dovecot: imap(test): Fatal: lzma errorcode when
> flushing : (null)
The code change should be i_fatal("unexpected lzma errorcode when flushing :
%d", ret);
since ret is an integer.
A logging change like that is a good idea and we have been meaning to do
something similar. It would help debugging, if you
could continue running it in your setup, where the error seems to occur quite
frequently. Also tell me if you figure out what
data or action triggers it.
br,
Teemu Huovila
