Perfect. Systems builds cleaning now.
Andrew
On 1/21/2026 11:34 AM, Aki Tuomi via dovecot wrote:
Maybe this is enough?
Aki
diff --git a/src/imap-hibernate/imap-hibernate-client.c
b/src/imap-hibernate/imap-hibernate-client.c
index b1c02db188..5fb588f3c3 100644
--- a/src/imap-hibernate/imap-hibernate-client.c
+++ b/src/imap-hibernate/imap-hibernate-client.c
@@ -12,6 +12,10 @@
#include "imap-client.h"
#include "imap-hibernate-client.h"
+#if defined(HAVE_SYS_MNTTAB_H)
+# include <sys/mkdev.h> /* Solaris */
+#endif
+
struct imap_hibernate_client {
struct connection conn;
struct imap_client *imap_client;
diff --git a/src/imap/imap-master-client.c b/src/imap/imap-master-client.c
index 9ae429e5cd..d90f8f2306 100644
--- a/src/imap/imap-master-client.c
+++ b/src/imap/imap-master-client.c
@@ -18,6 +18,10 @@
#include "imap-state.h"
#include "imap-master-client.h"
+#if defined(HAVE_SYS_MNTTAB_H)
+# include <sys/mkdev.h> /* Solaris */
+#endif
+
struct imap_master_client {
struct connection conn;
bool imap_client_created;
diff --git a/src/lib/mountpoint.c b/src/lib/mountpoint.c
index 3d2150ec6e..816d0d6f54 100644
--- a/src/lib/mountpoint.c
+++ b/src/lib/mountpoint.c
@@ -27,6 +27,7 @@
# include <stdio.h>
# include <sys/mnttab.h> /* Solaris */
# include <sys/mntent.h>
+# include <sys/mkdev.h>
# define MOUNTPOINT_SOLARIS
#else
# define MOUNTPOINT_UNKNOWN
On 19/01/2026 12:17 EET Andrew Watkins via dovecot [1]<[email protected]>
wrote:
On 1/16/2026 11:38 AM, Aki Tuomi wrote:
Can you see if
diff --git a/src/lib/mountpoint.c b/src/lib/mountpoint.c
index 3d2150ec6e..816d0d6f54 100644
--- a/src/lib/mountpoint.c
+++ b/src/lib/mountpoint.c
@@ -27,6 +27,7 @@
# include <stdio.h>
# include <sys/mnttab.h> /* Solaris */
# include <sys/mntent.h>
+# include <sys/mkdev.h>
# define MOUNTPOINT_SOLARIS
#else
# define MOUNTPOINT_UNKNOWN
helps?
Aki
Thanks, that worked.
There are 2 other files which use "makedev" which give the same error:
src/imap-hibernate/imap-hibernate-client.c: state_r->peer_dev =
makedev(peer_dev_major, peer_dev_minor);
src/imap/imap-master-client.c: makedev(peer_dev_major, peer_dev_minor);
So the "#include <sys/mkdev.h>" has to be added to them as well.
Question, which Definition to use so only added with SOLARIS?
I am test the installation now to see if it all works on Solaris 11.4
Thanks,
Andrew
On 1/16/2026 11:38 AM, Aki Tuomi wrote:
Can you see if
diff --git a/src/lib/mountpoint.c b/src/lib/mountpoint.c
index 3d2150ec6e..816d0d6f54 100644
--- a/src/lib/mountpoint.c
+++ b/src/lib/mountpoint.c
@@ -27,6 +27,7 @@
# include <stdio.h>
# include <sys/mnttab.h> /* Solaris */
# include <sys/mntent.h>
+# include <sys/mkdev.h>
# define MOUNTPOINT_SOLARIS
#else
# define MOUNTPOINT_UNKNOWN
helps?
Aki
Thanks, that worked.
There are 2 other files which use "makedev" which give the same error:
src/imap-hibernate/imap-hibernate-client.c: state_r->peer_dev =
makedev(peer_dev_major, peer_dev_minor);
src/imap/imap-master-client.c: makedev(peer_dev_major, peer_dev_minor);
So the "#include <sys/mkdev.h>" has to be added to them as well. Question,
which Definition to use so only added with SOLARIS?
I am test the installation now to see if it all works on Solaris 11.4
Thanks,
Andrew
_______________________________________________
dovecot mailing list -- [2][email protected]
To unsubscribe send an email to [3][email protected]
_______________________________________________
dovecot mailing list -- [4][email protected]
To unsubscribe send an email to [5][email protected]
WARNING: This email originated from outside of Birkbeck. Do not click links or
open attachments unless you recognise the sender. Under testing so any comments
[6][email protected]
References
Visible links
1. mailto:[email protected]
2. mailto:[email protected]
3. mailto:[email protected]
4. mailto:[email protected]
5. mailto:[email protected]
6. mailto:[email protected]
_______________________________________________
dovecot mailing list -- [email protected]
To unsubscribe send an email to [email protected]
