svn commit: r555564 - in /maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia: macro/snippet/SnippetMacro.java util/ByLineReaderSource.java util/HtmlTools.java

[ltheussl]

Author: ltheussl
Date: Thu Jul 12 03:23:23 2007
New Revision: 555564

URL: http://svn.apache.org/viewvc?view=rev&rev=555564
Log:
Minor clean-ups

Modified:
    
maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/macro/snippet/SnippetMacro.java
    
maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/util/ByLineReaderSource.java
    
maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/util/HtmlTools.java

Modified: 
maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/macro/snippet/SnippetMacro.java
URL: 
http://svn.apache.org/viewvc/maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/macro/snippet/SnippetMacro.java?view=diff&rev=555564&r1=555563&r2=555564
==============================================================================
--- 
maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/macro/snippet/SnippetMacro.java
 (original)
+++ 
maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/macro/snippet/SnippetMacro.java
 Thu Jul 12 03:23:23 2007
@@ -24,11 +24,9 @@
 import org.apache.maven.doxia.macro.MacroRequest;
 import org.apache.maven.doxia.sink.Sink;
 import org.codehaus.plexus.util.StringUtils;
-import org.codehaus.plexus.util.FileUtils;
 
 import java.io.IOException;
 import java.io.File;
-import java.io.FileNotFoundException;
 import java.net.MalformedURLException;
 import java.net.URL;
 import java.util.HashMap;

Modified: 
maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/util/ByLineReaderSource.java
URL: 
http://svn.apache.org/viewvc/maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/util/ByLineReaderSource.java?view=diff&rev=555564&r1=555563&r2=555564
==============================================================================
--- 
maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/util/ByLineReaderSource.java
 (original)
+++ 
maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/util/ByLineReaderSource.java
 Thu Jul 12 03:23:23 2007
@@ -163,11 +163,7 @@
         {
             throw new IllegalArgumentException( "argument can't be null" );
         }
-        if ( s.length() == 0 )
-        {
-            // dont do anything
-        }
-        else
+        if ( s.length() != 0 )
         {
             ungetLine();
             lastLine = s;

Modified: 
maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/util/HtmlTools.java
URL: 
http://svn.apache.org/viewvc/maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/util/HtmlTools.java?view=diff&rev=555564&r1=555563&r2=555564
==============================================================================
--- 
maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/util/HtmlTools.java
 (original)
+++ 
maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/util/HtmlTools.java
 Thu Jul 12 03:23:23 2007
@@ -225,6 +225,7 @@
 
             if ( ( Character.isLetterOrDigit( c ) ) || ( c == '-' ) || ( c == 
'_' ) || ( c == ':' ) || ( c == '.' ) )
             {
+                // TODO: why? see DOXIA-131
                 buffer.append( Character.toLowerCase( c ) );
             }
             // Not part of W3C recommandation, just to produce much nicer id