It seems like I did break something after all: the site-renderer test
now fails (btw, I only noticed it by accident on the continuum page,
there was no notification sent?).
It doesn't seem logical though to me, maybe this should be fixed in the
site renderer. Anyway, if I don't come up with a better solution, I'll
revert that part.
-Lukas
Lukas Theussl wrote:
The TOCMacro only generates the links, not the anchors, there is a test
case for it (and I didn't break it! :) ). Logically, I would say it's a
low-level sink (eg the SiteRendererSink) that should put the anchors in
place, not the parser (also I don't see eg the AptParser emit any
anchors for section titles, does it?). Section anchors only make sense
in an end-user presentation format (xhtml, pdf), you don't want explicit
anchors to clutter your xdoc or apt sources. But then, I'm not sure I
didn't break anything, I never used the macro.
-Lukas
Vincent Siveton wrote:
Hi Lukas,
2007/7/17, [EMAIL PROTECTED] <[EMAIL PROTECTED]>:
Author: ltheussl
Date: Tue Jul 17 13:45:47 2007
New Revision: 557051
URL: http://svn.apache.org/viewvc?view=rev&rev=557051
Log:
Various fixes to Xdoc parser:
- don't emit anchor for section titles (should be done by a sink if
desired)
I think it was handle by the TOCMacro. Could you have a glance on this?
- handle <h4>, <h5>, <h6> tags as section3, section4, section5
- distinguish between un-ordered and ordered list items
- only use the colspan attribute of table (header) cells if it is
non-null
- add lineBreak, horizontalRule, monospaced, definition list and img
parsing
- don't emit text events if text is just white space
Great! Thanks for these!
Cheers,
Vincent
[SNIP]
