Dear Clayton,

The pull request 383 has been integrated in the main branch.

Albert

On Mon, Aug 24, 2015 at 11:11 AM, Clayton <clayt...@gmx.com> wrote:

> Hi Albert, I just built your pull request
>
>         https://github.com/doxygen/doxygen/pull/383
>
> from source and tested it on a hundred+ github javascript repositories,
> it works as expected: lots of javascript output. We would really like to
> see this patch merged into master.
>
> Plus, the current master quite likely gives many people the impression
> that doxygen processing of javascript is broken, which it is not.
>
> Thanks for writing the fix,
> Clayton
>
> On Mon, 17 Aug 2015 18:44:48 +0200
> Albert <albert.te...@gmail.com> wrote:
>
> > Bug report is not really needed.
> >
> > I don't think the other places are in conflict.
> > There is no separate javascript parser but it is more or less
> > integrated in the c parser. The g_lang2extMap tells that javascript
> > type of files have to be parsed by the c parser and that the type of
> > language is SrcLangExt_JS. With the later it is possible to ask in
> > the code which language a file has and do special things for this
> > language.
> >
> > The initDefaultExtensionMapping maps the files extension to the
> > language type of files.
> >
> > Albert
> >
> >
> >
> >
> > On Mon, Aug 17, 2015 at 10:09 AM, Clayton <clayt...@gmx.com> wrote:
> >
> > > Thanks for the quick work, Albert. Does this mean a bug report is
> > > now no longer needed? (That's quite the list of bugs in
> > > Bugzilla....)
> > >
> > > It looks to me like your patch leaves js in. And I am in fact
> > > seeing at least two different references in util.cpp, which also
> > > might be in conflict:
> > >
> > > g_lang2extMap[] =
> > > {
> > > //  language       parser           parser option
> > >   { "javascript",  "c",             SrcLangExt_JS       },
> > >
> > >
> > > void initDefaultExtensionMapping()
> > > {
> > >   g_extLookup.setAutoDelete(TRUE);
> > >   //                  extension      parser id
> > >   updateLanguageMapping(".as",       "javascript");
> > >   updateLanguageMapping(".js",       "javascript");
> > >
> > > The second reference above gives the impression that there is an
> > > internal doxygen parser for javascript? Really??
> > >
> > > Clayton
> > >
> > >
> > >
> > >
> > > On Sun, 16 Aug 2015 18:21:46 +0200
> > > Albert <albert.te...@gmail.com> wrote:
> > >
> > > > I've just pushed a proposed patch to github (pull request 383)
> > > >
> > > > Albert
> > > >
> > > > On Sun, Aug 16, 2015 at 4:06 PM, Albert <albert.te...@gmail.com>
> > > > wrote:
> > > >
> > > > > The following does not yet solve your problem, but points in the
> > > > > direction where we have to look to solve the problem:
> > > > > There is in util.cpp another list which does contain .js, looks
> > > > > like a small inconsistency between config.xml, util.cpp and
> > > > > config.l. Please file a bug report to signal this discrepancy.
> > > > >
> > > > > Albert
> > > > >
> > > > >
> > > > > On Sun, Aug 16, 2015 at 3:09 PM, Clayton <clayt...@gmx.com>
> > > > > wrote:
> > > > >
> > > > >> On Sun, 16 Aug 2015 14:05:56 +0200
> > > > >> Stefan Pendl <stefan.pendl...@gmail.com> wrote:
> > > > >>
> > > > >> > Am 16.08.2015 um 13:45 schrieb Clayton:
> > > > >> > > Hi doxygen,
> > > > >> > >
> > > > >> > > I am looking at the config file and writing to ask if I am
> > > > >> > > missing something.
> > > > >> > >
> > > > >> > > I am using
> > > > >> > >
> > > > >> > >     FILE_PATTERNS = *.js
> > > > >> > >     FILTER_PATTERNS = *.js=plugins/js2doxy/js2doxy.pl
> > > > >> >
> > > > >> > From the help file topic "Configuration => Configuration
> > > > >> > options related to the input files => FILE_PATTERNS" it
> > > > >> > seems that *.js is included in the default already.
> > > > >> >
> > > > >> > Is your doxygen version less than v1.8.10?
> > > > >>
> > > > >> Hi Stefan, the help is not the same as the code, from
> > > > >> src/config.l in a very recent clone of the source, I believe
> > > > >> this to be the ACTUAL default list of file patterns:
> > > > >>
> > > > >>   QStrList &filePatternList = Config_getList("FILE_PATTERNS");
> > > > >>   if (filePatternList.isEmpty())
> > > > >>   {
> > > > >>     filePatternList.append("*.c");
> > > > >>     filePatternList.append("*.cc");
> > > > >>     filePatternList.append("*.cxx");
> > > > >>     filePatternList.append("*.cpp");
> > > > >>     filePatternList.append("*.c++");
> > > > >>     filePatternList.append("*.java");
> > > > >>     filePatternList.append("*.ii");
> > > > >>     filePatternList.append("*.ixx");
> > > > >>     filePatternList.append("*.ipp");
> > > > >>     filePatternList.append("*.i++");
> > > > >>     filePatternList.append("*.inl");
> > > > >>     filePatternList.append("*.h");
> > > > >>     filePatternList.append("*.hh");
> > > > >>     filePatternList.append("*.hxx");
> > > > >>     filePatternList.append("*.hpp");
> > > > >>     filePatternList.append("*.h++");
> > > > >>     filePatternList.append("*.idl");
> > > > >>     filePatternList.append("*.odl");
> > > > >>     filePatternList.append("*.cs");
> > > > >>     filePatternList.append("*.php");
> > > > >>     filePatternList.append("*.php3");
> > > > >>     filePatternList.append("*.inc");
> > > > >>     filePatternList.append("*.m");
> > > > >>     filePatternList.append("*.mm");
> > > > >>     filePatternList.append("*.dox");
> > > > >>     filePatternList.append("*.py");
> > > > >>     filePatternList.append("*.f90");
> > > > >>     filePatternList.append("*.f");
> > > > >>     filePatternList.append("*.for");
> > > > >>     filePatternList.append("*.vhd");
> > > > >>     filePatternList.append("*.vhdl");
> > > > >>     filePatternList.append("*.tcl");
> > > > >>     filePatternList.append("*.md");
> > > > >>     filePatternList.append("*.markdown");
> > > > >>
> > > > >> *.js is not in there. The plugin is necessary, the point is,
> > > > >> how to get the plugin to integrate with the default list
> > > > >> automatically, without explicitly adding the default list to
> > > > >> FILE_PATTERNS.
> > > > >>
> > > > >> Thanks,
> > > > >> Clayton
> > > > >>
> > > > >>
> > > > >>
> > >
> ------------------------------------------------------------------------------
> > > > >> _______________________________________________
> > > > >> Doxygen-users mailing list
> > > > >> Doxygen-users@lists.sourceforge.net
> > > > >> https://lists.sourceforge.net/lists/listinfo/doxygen-users
> > > > >>
> > > > >
> > > > >
> > >
> > >
> > >
> ------------------------------------------------------------------------------
> > > _______________________________________________
> > > Doxygen-users mailing list
> > > Doxygen-users@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/doxygen-users
> > >
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Doxygen-users mailing list
> Doxygen-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/doxygen-users
>
------------------------------------------------------------------------------
_______________________________________________
Doxygen-users mailing list
Doxygen-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/doxygen-users

Reply via email to