Hi Thomas,
push your changes to Gerrit (including the tests so I can change the STF
API)
Might it be possible to commit the changes without tests? We have manually tested the functionality and
everything was working as expected.
No ... we have tested XXX ... later ... YYY has found bugs on XXX even
it was manually tested.
If you change UI stuff, make sure the STF regression runs smoothly , or
you will be blamed. (I currently blamed myself for my current STF
patch, see http://saros-build.imp.fu-berlin.de/jenkins/job/Test_STF/520/)
BR,
Stefan
Am 01.12.2012 20:18, schrieb Thomas Benndorf:
Dear Saros community,
we would like to share our approach on feature request #3392259 'No
notification about new chat entries'. [1]
Following the discussion about the cases in which a visual
notification should take place we have implemented such functionality
for inactive chat tabs but not for hidden a Saros view or a hidden
Eclipse window.
To notify the user we change the chat tab text from "user@host" to
"(i) user@host" where i stands for the number of missed or unread
messages. Furthermore the text font is changed bold. The notification
is removed when the tab regains focus. A screenshot is attached to
this email.
At this point we got some problems implementing the STF-Tests. The
idea was to test notifications similiar to ChatViewTest, i.e. to
implement methods getChatTabTitle() in IChatroom.
We have therefore modified ChatViewTest to support three participants
in the session and added a new test method. It works the same way as
testMultipleOpenedChatRooms() and additionally involves CARL.
Unfortunately we always get WidgetNotFoundExceptions when opening a
chat with Carl after having opened a chat with Bob.
>
ALICE.superBot().views().sarosView().selectParticipant(BOB.getJID()).openChat();
>
ALICE.superBot().views().sarosView().selectParticipant(CARL.getJID()).openChat();
As we are only limited familiar with SWTBot and STF, we are not sure
what's the reason for this, but hope that someone of you might be able
to see the problem here.
Might it be possible to commit the changes without tests? We have
manually tested the functionality and everything was working as expected.
Christoph has created an account in Gerrit which is not activated yet.
We would push our results right after activation then.
We hope we did not miss any necessary point and thank you very much in
advance.
Best Regards,
Chrtistoph and Thomas
[1]
http://sourceforge.net/tracker/?func=detail&aid=3392259&group_id=167540&atid=843362
------------------------------------------------------------------------------
Keep yourself connected to Go Parallel:
INSIGHTS What's next for parallel hardware, programming and related areas?
Interviews and blogs by thought leaders keep you ahead of the curve.
http://goparallel.sourceforge.net
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel
------------------------------------------------------------------------------
Keep yourself connected to Go Parallel:
INSIGHTS What's next for parallel hardware, programming and related areas?
Interviews and blogs by thought leaders keep you ahead of the curve.
http://goparallel.sourceforge.net
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel
