Oh well I didn't saw this on my phone... in this case nevermind ^^
BR
Matthias
------------------------------
Von: Zieris, Franz <franz.zie...@fu-berlin.de>
Gesendet: 04.03.2015 16:26
An: Matthias Bohnstedt <matthias.bohnst...@gmail.com>
Cc: dpp-devel@lists.sourceforge.net
Betreff: RE: [DPP-Devel] Add IDE specific tag for commit messages
Hi Matthias,
I already agreed with Christian’s reasoning:
http://article.gmane.org/gmane.comp.ide.eclipse.saros.devel/1301
Franz
*From:* Matthias Bohnstedt [mailto:matthias.bohnst...@gmail.com]
*Sent:* Wednesday, March 04, 2015 4:24 PM
*To:* Christian Cikryt; Zieris, Franz
*Cc:* dpp-devel@lists.sourceforge.net
*Subject:* AW: [DPP-Devel] Add IDE specific tag for commit messages
Thank you for the input Franz :)
If I understand you correctly, you are against the including of the
location of the changes, as this information are implicit and can be
extracted as you describe it. ( = at least you find it unnecessary)
I'm not 'directly' propose that we should do this, I just recognized that
this IS what we do (at least in the last month). And if we adding thus
information anyway, we might as well define common short tag for them.
My point is: While you have some good arguments, that this would mix things
up and isn't really needed, the 'reality' tells a different story:
If you look at our current commits you find the term Eclipse, IntelliJ,
HTML-UI pretty often. I think it's helpful. So why not shorten this terms
by using predefined tags?
And I agree with Christian point: We only adding meta information, not
mixing up the current TAG semantic with this.
BR
Matthias
------------------------------
*Von: *Christian Cikryt <c.cik...@googlemail.com>
*Gesendet: *04.03.2015 10:32
*An: *Zieris, Franz <franz.zie...@fu-berlin.de>
*Cc: *Matthias Bohnstedt <matthias.bohnst...@gmail.com>;
dpp-devel@lists.sourceforge.net
*Betreff: *Re: [DPP-Devel] Add IDE specific tag for commit messages
The new tags are meant to be an addition and not a replacement of the
current ones.
They aim to unify and shorten the commit messages that contain location
information.
2015-03-04 9:56 GMT+01:00 Zieris, Franz <franz.zie...@fu-berlin.de>:
Please be aware that this would mix up the tag semantics.
Currently, the tags tell you what kind of change this is: Something that
affects the user, something that removes a defect, something that improves
internal code quality, something that changes the interface of bigger
components (i.e. [UI], [FIX], [INTERNAL], [API]).
Your proposal would state the location of the changes – something that is
already contained in the commit itself – whereas the nature of the change
is something that cannot be easily extracted from the diff itself.
To list all commits affecting intellij:
$> git log --oneline -- de.fu_berlin.inf.dpp.intellij
Using the „[I]“ tag:
$> git log --oneline --grep="\[I\]"
Sure, the first way (using git log’s “path” parameter) would still work
since it’s independent from the commit message. But what problems would the
new tags solve?
· Getting an overview on the command line: See above.
· Getting an overview in Eclipse: The History view as four options
to filter commits:
o “Show all changes in repository containing the selected resource”
(yellow database icon).
o “Show all changes in project containing the selected resource”
(blue-ish folder icon) à that’s the one you probably want.
o “Show all changes in parent folder of the selected resource” (standard
folder icon).
o “Show all changes of selected resource and its children” (grey-ish
stack icon).
· Getting in overview on GitHub: Just select the folder or resource
you’re interested in and then click on “commits for this branch”, e.g.
https://github.com/saros-project/saros/commits/master/de.fu_berlin.inf.dpp.intellij
So “-1” from my side.
Franz
*From:* Matthias Bohnstedt [mailto:matthias.bohnst...@gmail.com
<matthias.bohnst...@gmail.com>]
*Sent:* Monday, March 02, 2015 2:35 PM
*To:* Christian Cikryt
*Cc:* dpp-devel@lists.sourceforge.net
*Subject:* Re: [DPP-Devel] Add IDE specific tag for commit messages
To get this settled, my suggestion is this pattern:
[E] = Eclipse - (optional can be combined with other tags) This commit only
affects the Eclipse part of Saros.
[I] = IntelliJ - (optional can be combined with other tags) This commit
only affects the IntelliJ part of Saros.
[HTML] - This commit affects the HTML UI (architecture as well as layout).
I am unsure about this one: [Core] = Core - This commit affects the core
Project.
I would say we wait a week for feedback (till next monday) and after that I
would change this on our project page accordingly.
Answer:
+ for I agree
- for I disagree (In this case a comment, or counter proposal would be
nice).
BR,
Matthias
2015-02-26 18:29 GMT+01:00 Christian Cikryt <c.cik...@googlemail.com>:
Currently, commit messages already contain "Eclipse", "IntelliJ" or
"HTML-UI" (unabbreviated).
Hasn't been a problem so far.
2015-02-26 18:04 GMT+01:00 Arsenij E Solovjev <xeper...@gmail.com>:
Keep in mind there is an 80 character limit on the commit title, so double
tags would not be practical.
On 02/26/2015 04:32 PM, Christian Cikryt wrote:
Hi *,
I think that is a good idea. I would also add a tag for the HTML UI
prototype, e.g. [HTML-UI].
I personally would prefer double tags like [INTERNAL][Eclipse], as they are
more verbose and might be easier to read and to filter.
But it does not really matter, we just have to agree on one version.
BR,
Christian
2015-02-24 10:58 GMT+01:00 Matthias Bohnstedt <matthias.bohnst...@gmail.com
>:
Hello all,
in my last reviews and commits I find that the current [TAG]s as described
on the project page [1] are not satisfying our needs anymore.
Some commits only effect one IDE and not both (or maybe later more) and we
get commit headlines headers like:
[NOP] IntelliJ ....
[Internal] Eclipse ...
Long story short: I think it would be useful to have a tag modifier to
address that a commit only effect a specific IDE:
[TAG/E] = This is a change only in Saros/E, f.E. [UI/E] Change
BrowserCreator.
[TAG/J] = This is change only effectingSaros/J
This would save some space in the commit headlines.
I would change the website if everybode is fine with this idea.
Best regrades,
Matthias
[1]http://www.saros-project.org/coderules#before_committing
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website,
sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for
all
things parallel software development, from weekly thought leadership blogs
to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website,
sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for
all
things parallel software development, from weekly thought leadership blogs
to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website,
sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for
all
things parallel software development, from weekly thought leadership blogs
to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website,
sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for
all
things parallel software development, from weekly thought leadership blogs
to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel
